Skip to content

Commit 910f654

Browse files
committed
rebase
1 parent 33c644d commit 910f654

File tree

10 files changed

+32
-17
lines changed

10 files changed

+32
-17
lines changed

crates/bevy_asset/src/reflect.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ pub struct ReflectAsset {
1818
assets_resource_type_id: TypeId,
1919

2020
get: fn(&World, HandleUntyped) -> Option<&dyn PartialReflect>,
21-
get_unchecked_mut: unsafe fn(UnsafeWorldCell<'_>, HandleUntyped) -> Option<&mut dyn PartialReflect>,
21+
get_unchecked_mut:
22+
unsafe fn(UnsafeWorldCell<'_>, HandleUntyped) -> Option<&mut dyn PartialReflect>,
2223
add: fn(&mut World, &dyn PartialReflect) -> HandleUntyped,
2324
set: fn(&mut World, HandleUntyped, &dyn PartialReflect) -> HandleUntyped,
2425
len: fn(&World) -> usize,

crates/bevy_core_pipeline/src/bloom/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use bevy_ecs::{
88
world::{FromWorld, World},
99
};
1010
use bevy_math::{UVec2, UVec4, Vec4};
11-
use bevy_reflect::{PartialReflect, TypeUuid, Reflect};
11+
use bevy_reflect::{PartialReflect, Reflect, TypeUuid};
1212
use bevy_render::{
1313
camera::ExtractedCamera,
1414
extract_component::{

crates/bevy_ecs/src/reflect.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,8 @@ pub struct ReflectResourceFns {
275275
///
276276
/// # Safety
277277
/// The function may only be called with an [`UnsafeWorldCell`] that can be used to mutably access the relevant resource.
278-
pub reflect_unchecked_mut: unsafe fn(UnsafeWorldCell<'_>) -> Option<Mut<'_, dyn PartialReflect>>,
278+
pub reflect_unchecked_mut:
279+
unsafe fn(UnsafeWorldCell<'_>) -> Option<Mut<'_, dyn PartialReflect>>,
279280
/// Function pointer implementing [`ReflectResource::copy()`].
280281
pub copy: fn(&World, &mut World),
281282
}

crates/bevy_reflect/bevy_reflect_derive/src/impls/enums.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use crate::derive_data::{EnumVariant, EnumVariantFields, ReflectEnum, StructField};
22
use crate::enum_utility::{get_variant_constructors, EnumVariantConstructors};
33
use crate::fq_std::{FQBox, FQOption, FQResult};
4-
use crate::impls::{impl_typed, impl_full_reflect};
4+
use crate::impls::{impl_full_reflect, impl_typed};
55
use crate::utility::extend_where_clause;
66
use proc_macro::TokenStream;
77
use proc_macro2::{Ident, Span};
@@ -91,8 +91,8 @@ pub(crate) fn impl_enum(reflect_enum: &ReflectEnum) -> TokenStream {
9191
let get_type_registration_impl = reflect_enum
9292
.meta()
9393
.get_type_registration(&where_clause_options);
94-
95-
let impl_full_reflect = impl_full_reflect(reflect_enum.meta());
94+
95+
let impl_full_reflect = impl_full_reflect(reflect_enum.meta(), &where_clause_options);
9696

9797
let (impl_generics, ty_generics, where_clause) =
9898
reflect_enum.meta().generics().split_for_impl();

crates/bevy_reflect/bevy_reflect_derive/src/impls/full_reflect.rs

+9-2
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,22 @@ use quote::quote;
33
use crate::{
44
derive_data::ReflectMeta,
55
fq_std::{FQAny, FQBox, FQResult},
6+
utility::{extend_where_clause, WhereClauseOptions},
67
};
78

8-
pub(crate) fn impl_full_reflect(meta: &ReflectMeta) -> proc_macro2::TokenStream {
9+
pub(crate) fn impl_full_reflect(
10+
meta: &ReflectMeta,
11+
where_clause_options: &WhereClauseOptions,
12+
) -> proc_macro2::TokenStream {
913
let type_name = meta.type_name();
1014
let bevy_reflect_path = meta.bevy_reflect_path();
1115

1216
let (impl_generics, ty_generics, where_clause) = meta.generics().split_for_impl();
17+
18+
let where_reflect_clause = extend_where_clause(where_clause, where_clause_options);
19+
1320
quote! {
14-
impl #impl_generics #bevy_reflect_path::Reflect for #type_name #ty_generics #where_clause {
21+
impl #impl_generics #bevy_reflect_path::Reflect for #type_name #ty_generics #where_reflect_clause {
1522
#[inline]
1623
fn into_any(self: #FQBox<Self>) -> #FQBox<dyn #FQAny> {
1724
self

crates/bevy_reflect/bevy_reflect_derive/src/impls/structs.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ pub(crate) fn impl_struct(reflect_struct: &ReflectStruct) -> TokenStream {
105105
);
106106

107107
let get_type_registration_impl = reflect_struct.get_type_registration(&where_clause_options);
108-
109-
let impl_full_reflect = impl_full_reflect(reflect_struct.meta());
108+
109+
let impl_full_reflect = impl_full_reflect(reflect_struct.meta(), &where_clause_options);
110110

111111
let (impl_generics, ty_generics, where_clause) =
112112
reflect_struct.meta().generics().split_for_impl();

crates/bevy_reflect/bevy_reflect_derive/src/impls/tuple_structs.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ pub(crate) fn impl_tuple_struct(reflect_struct: &ReflectStruct) -> TokenStream {
8989
bevy_reflect_path,
9090
);
9191

92-
let impl_full_reflect = impl_full_reflect(reflect_struct.meta());
92+
let impl_full_reflect = impl_full_reflect(reflect_struct.meta(), &where_clause_options);
9393

9494
let (impl_generics, ty_generics, where_clause) =
9595
reflect_struct.meta().generics().split_for_impl();

crates/bevy_reflect/bevy_reflect_derive/src/impls/values.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ pub(crate) fn impl_value(meta: &ReflectMeta) -> TokenStream {
3535
},
3636
bevy_reflect_path,
3737
);
38-
39-
let impl_full_reflect = impl_full_reflect(meta);
38+
39+
let impl_full_reflect = impl_full_reflect(meta, &where_clause_options);
4040

4141
let (impl_generics, ty_generics, where_clause) = meta.generics().split_for_impl();
42-
42+
4343
let get_type_registration_impl = meta.get_type_registration(&where_clause_options);
4444

4545
TokenStream::from(quote! {

crates/bevy_reflect/src/lib.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -1289,11 +1289,17 @@ bevy_reflect::tests::should_reflect_debug::Test {
12891289
let mut v = vec3(1.0, 2.0, 3.0);
12901290

12911291
assert_eq!(
1292-
*v.reflect_path("x").unwrap().try_downcast_ref::<f32>().unwrap(),
1292+
*v.reflect_path("x")
1293+
.unwrap()
1294+
.try_downcast_ref::<f32>()
1295+
.unwrap(),
12931296
1.0
12941297
);
12951298

1296-
*v.reflect_path_mut("y").unwrap().try_downcast_mut::<f32>().unwrap() = 6.0;
1299+
*v.reflect_path_mut("y")
1300+
.unwrap()
1301+
.try_downcast_mut::<f32>()
1302+
.unwrap() = 6.0;
12971303

12981304
assert_eq!(v.y, 6.0);
12991305
}

crates/bevy_ui/src/focus.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use bevy_ecs::{
1010
};
1111
use bevy_input::{mouse::MouseButton, touch::Touches, Input};
1212
use bevy_math::Vec2;
13-
use bevy_reflect::{PartialReflect, ReflectDeserialize, ReflectSerialize, Reflect};
13+
use bevy_reflect::{PartialReflect, Reflect, ReflectDeserialize, ReflectSerialize};
1414
use bevy_render::{camera::NormalizedRenderTarget, prelude::Camera, view::ComputedVisibility};
1515
use bevy_transform::components::GlobalTransform;
1616

0 commit comments

Comments
 (0)