Skip to content

Commit 06c49d3

Browse files
MrGVSVtim-blackbird
andcommitted
Direct collect boxed slices
Co-authored-by: ira <[email protected]>
1 parent 7bd305d commit 06c49d3

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

crates/bevy_reflect/src/enums/enum_trait.rs

+2-5
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,14 @@ impl EnumInfo {
155155
.map(|(index, variant)| (variant.name(), index))
156156
.collect::<HashMap<_, _>>();
157157

158-
let variant_names = variants
159-
.iter()
160-
.map(|variant| variant.name())
161-
.collect::<Vec<_>>();
158+
let variant_names = variants.iter().map(|variant| variant.name()).collect();
162159

163160
Self {
164161
name,
165162
type_name: std::any::type_name::<TEnum>(),
166163
type_id: TypeId::of::<TEnum>(),
167164
variants: variants.to_vec().into_boxed_slice(),
168-
variant_names: variant_names.into_boxed_slice(),
165+
variant_names,
169166
variant_indices,
170167
}
171168
}

crates/bevy_reflect/src/enums/variants.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ impl StructVariantInfo {
8787
/// Create a new [`StructVariantInfo`].
8888
pub fn new(name: &'static str, fields: &[NamedField]) -> Self {
8989
let field_indices = Self::collect_field_indices(fields);
90-
let field_names = fields.iter().map(|field| field.name()).collect::<Vec<_>>();
90+
let field_names = fields.iter().map(|field| field.name()).collect();
9191
Self {
9292
name,
9393
fields: fields.to_vec().into_boxed_slice(),
94-
field_names: field_names.into_boxed_slice(),
94+
field_names,
9595
field_indices,
9696
}
9797
}

crates/bevy_reflect/src/struct_trait.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,14 @@ impl StructInfo {
9292
.map(|(index, field)| (field.name(), index))
9393
.collect::<HashMap<_, _>>();
9494

95-
let field_names = fields.iter().map(|field| field.name()).collect::<Vec<_>>();
95+
let field_names = fields.iter().map(|field| field.name()).collect();
9696

9797
Self {
9898
name,
9999
type_name: std::any::type_name::<T>(),
100100
type_id: TypeId::of::<T>(),
101101
fields: fields.to_vec().into_boxed_slice(),
102-
field_names: field_names.into_boxed_slice(),
102+
field_names,
103103
field_indices,
104104
}
105105
}

0 commit comments

Comments
 (0)