Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: coloring improvements #256

Open
1 of 6 tasks
balupton opened this issue Oct 15, 2024 · 0 comments
Open
1 of 6 tasks

Improvement: coloring improvements #256

balupton opened this issue Oct 15, 2024 · 0 comments
Labels
ongoing Ongoing efforts of incremental improvements PR / Bounty only External demand, as such, external funding / effort is required to make this happen

Comments

@balupton
Copy link
Member

balupton commented Oct 15, 2024

I won't have time for this, however I would welcome someone to do a PR for it.

  • ensure all background and foreground color combinations are suitable for color-blind people
  • check if there are styles being invoked that are missing
    • perhaps echo-style can write to a $DOROTHY/state/warnings.txt file, that is dumped when new terminals are open; this can also be used for deprecations
  • provide good2, notice2, neutral2, error2 styles; consider removing good, successful, negative styles
    • the thing with these numbered styles, is they need a corresponding --code-BLAH= style, and underlines can't be used as the numbered styles include trailing spaces, e.g. --error2='this path is missing: ' --code-error2='a missing path'
  • consider redoing confirm (from ask, choose, confirm: comprehensive support of TTY modes and capabilities #254) with styles.bash rather than echo-style calls
@balupton balupton added enhancement Improvement or suggestion PR / Bounty only External demand, as such, external funding / effort is required to make this happen labels Oct 15, 2024
@balupton balupton changed the title Improvement: coloring improvements, and remove echo-error Improvement: coloring improvements Oct 29, 2024
@balupton balupton added ongoing Ongoing efforts of incremental improvements and removed enhancement Improvement or suggestion labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing efforts of incremental improvements PR / Bounty only External demand, as such, external funding / effort is required to make this happen
Development

No branches or pull requests

1 participant