Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple rotation-wrapper spans added instead of a single with the max height needed #22

Open
jamesmanning opened this issue Aug 8, 2014 · 1 comment

Comments

@jamesmanning
Copy link

-brody, all the spins, and rotate all require a rotation wrapper for the added height spacing, but each one adds its own.

So:

  • -brody-spin will have 2 rotation-wrapper spans
  • -spin-brody-45 will have 3 rotation-wrapper spans
  • -brody-brody-brody-brody-brody will have 5 rotation-wrapper spans

Since the resulting effect is just more spacing than necessary, it doesn't appear to break any functionality (just adds more space than necessary)

An 'extreme' test case to show the effect would be something like [](/ajlie-brody-brody-brody-brody-brody-brody-brody-brody-brody-brody-brody)

@jamesmanning
Copy link
Author

A few test cases I wrote for my library, in case they're helpful here:

https://github.com/jamesmanning/emote-expansion/blob/d097cc22127cb700ca0dfc0989074116023e2623/spec/EmoteExpander.spec.js#L106-L126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant