Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing ReadBuffer for &mut [C;N] might be unsound #24

Open
jounathaen opened this issue Mar 27, 2024 · 0 comments
Open

Implementing ReadBuffer for &mut [C;N] might be unsound #24

jounathaen opened this issue Mar 27, 2024 · 0 comments

Comments

@jounathaen
Copy link
Collaborator

As mentioned in #23, we basically implement ReadBuffer for all &mut [C;N] in

unsafe impl<'a, C: PixelColor, const N: usize> DMACapableFrameBufferBackend for &'a mut [C; N] {

This might be problematic because the slice could not be suitable for DMA access. Maybe it is already fine as is, but as I haven't fully thought this through, I'll leave this as an issue for now.

@jounathaen jounathaen changed the title Implementing ReadBuffer for &mut [C;N] might be unsound Implementing ReadBuffer for &mut [C;N] might be unsound Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant