-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom helm command line options #34
Comments
@tjcrone yeah, I think a '--helm-options' flag maybe? That could just get passed in to helm. |
Okay. I'm going to have to think about how to pass a list of flags and values for another program through the hubploy argparse with a --helm-options flag. Maybe a list of strings. Maybe a dict. I have not passed a set of options for another program to argparse before. If you have a preferred method, please let me know. |
Kindof need a way to get **kwargs working with argparse and the CLI. Googling ... |
I'd suggest taking it in as a single string, splitting it with shlex.split, and then passing it to helm. |
Another option would be to add "--force=False" and "--timeout=300" as separate argparse options to hubploy, and then pass them on to helm. I kindof like this idea better. What do you think? If you do not like this, I will do it as a string like you suggest. |
Sometimes I need to include --force because of a failed deployment on the first deployment, or include the --timeout option to helm. When I need to do that I hardcode these, and use my version of hubploy. I'm wondering if we could include an option for custom helm options instead? @yuvipanda, I'm happy to make these changes and PR if you suggest a preferred way of doing this. Thanks!
The text was updated successfully, but these errors were encountered: