New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm] Support service annotations #72

Open

KIVagant opened this issue Jun 15, 2021 · 0 comments

KIVagant commented Jun 15, 2021

Please add support for custom object annotations.

# templates/service.yaml

apiVersion: v1
kind: Service
metadata:
  name: {{ include "kubeview.fullname" . }}
{{- if .Values.service.annotations }}
  annotations:
{{ toYaml .Values.service.annotations | indent 4 }}
{{- end }}
...

# values.yaml

service:
  # annotations:
  #   service.beta.kubernetes.io/aws-load-balancer-internal: "0.0.0.0/0"
  type: ClusterIP     # ← as per https://github.com/benc-uk/kubeview/issues/71

Same improvement can be added to other Yaml-resources.

Additionally, it would be nice to support extra labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment