Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Soundcloud JS wrapper to manual OAuth management #11

Open
benbelow opened this issue Oct 2, 2017 · 1 comment
Open

Migrate from Soundcloud JS wrapper to manual OAuth management #11

benbelow opened this issue Oct 2, 2017 · 1 comment

Comments

@benbelow
Copy link
Owner

benbelow commented Oct 2, 2017

Chrome on desktop handles certain popups by opening a new tab instead of a popup. This means that on redirect finishing, the page is a new version of the tab and doesn't remember it should be requesting something.

Two ways around this:

(1) have the state of the page remember the user's OAuth token and keep them signed in across visits

(PROBABLY A GOOD IDEA ANYWAY!)

although it means the first time you try to make a playlist, you'll instead login and start again on a duplicate tab

(2) follow https://stackoverflow.com/questions/44815559/chrome-how-to-open-popup-in-new-window-instead-of-new-tab-20170629-chrome-59-0 to get the popup to open as a popup proper, instead of a new tab

@benbelow
Copy link
Owner Author

benbelow commented Oct 2, 2017

N.B. (1) will require in session memory, which means a backend. Might mean I need to re-think hosting strategy - look into firebase options for a backend express / mongo setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant