Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non utf-8 payloads #10

Open
cadubentzen opened this issue Nov 17, 2020 · 0 comments
Open

Support for non utf-8 payloads #10

cadubentzen opened this issue Nov 17, 2020 · 0 comments

Comments

@cadubentzen
Copy link

Currently

assumes that the data provided is an UTF-8 string which is then converted to Buffer.

However when using libraries such as kinesis-aggregation, the data is actually a protobuf as a Buffer already.

In a downstream branch I managed to solve it but had to change KinesisEvent's signature, which breaks the public api.

As I'm not that experienced with TypeScript, maybe there is a nice way to accomplish this that I'm not aware. Any pointers welcome and I could send a PR 😉

@cadubentzen cadubentzen changed the title No support for non utf-8 payloads Support for non utf-8 payloads Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant