Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment operators don't set "engaged" flag #96

Closed
jiixyj opened this issue Dec 31, 2024 · 2 comments
Closed

Assignment operators don't set "engaged" flag #96

jiixyj opened this issue Dec 31, 2024 · 2 comments

Comments

@jiixyj
Copy link
Contributor

jiixyj commented Dec 31, 2024

The rhs is correctly constructed into place, but the engaged_ flag is not set: https://github.com/bemanproject/optional26/blob/f4cd4b7c3f3c49a0cfc0dba6ef88665cb64f701d/include/beman/optional26/optional.hpp#L526-L527
@jiixyj
Copy link
Contributor Author

jiixyj commented Dec 31, 2024

PR with a fix and some tests: #97

@jiixyj
Copy link
Contributor Author

jiixyj commented Jan 2, 2025

Fixed by #97 .

@jiixyj jiixyj closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiixyj