Skip to content

Commit 492348f

Browse files
committed
fixed and issue exposed by gcc (although that's not the correct fix)
1 parent 54059ae commit 492348f

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

include/beman/execution26/detail/basic_sender.hpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -72,25 +72,25 @@ namespace beman::execution26::detail
7272
#if __cpp_explicit_this_parameter < 202110L
7373
template <typename Env>
7474
auto get_completion_signatures(Env&&) &&
75-
-> ::beman::execution26::detail::completion_signatures_for<basic_sender&&, Env>
75+
-> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env>
7676
{
7777
return {};
7878
}
7979
template <typename Env>
8080
auto get_completion_signatures(Env&&) const&&
81-
-> ::beman::execution26::detail::completion_signatures_for<basic_sender const&&, Env>
81+
-> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env>
8282
{
8383
return {};
8484
}
8585
template <typename Env>
8686
auto get_completion_signatures(Env&&) &
87-
-> ::beman::execution26::detail::completion_signatures_for<basic_sender&, Env>
87+
-> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env>
8888
{
8989
return {};
9090
}
9191
template <typename Env>
9292
auto get_completion_signatures(Env&&) const&
93-
-> ::beman::execution26::detail::completion_signatures_for<basic_sender const&, Env>
93+
-> ::beman::execution26::detail::completion_signatures_for<basic_sender, Env>
9494
{
9595
return {};
9696
}

include/beman/execution26/detail/common.hpp

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
#if defined(__GNUC__)
1010
# pragma GCC diagnostic ignored "-Wmissing-braces"
11+
# pragma GCC diagnostic ignored "-Wmissing-field-initializers"
1112
#endif
1213

1314
#if defined(__clang__)

src/beman/execution26/tests/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
33

44
list(APPEND execution_tests
5-
meta-transform.pass
65
exec-then.pass
6+
exec-just.pass
7+
meta-transform.pass
78
exec-read-env.pass
89
exec-get-delegation-scheduler.pass
910
exec-snd-apply.pass
@@ -12,7 +13,6 @@ list(APPEND execution_tests
1213
exec-into-variant.pass
1314
exec-run-loop-types.pass
1415
exec-run-loop-general.pass
15-
exec-just.pass
1616
exec-snd-expos.pass
1717
exec-recv-concepts.pass
1818
forward-like.pass

src/beman/execution26/tests/exec-just.pass.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -181,4 +181,8 @@ auto main() -> int
181181
{
182182
test_just_constraints();
183183
test_just();
184+
using type = test_detail::call_result_t<test_std::get_completion_signatures_t,
185+
decltype(test_std::just()), test_std::empty_env>;
186+
187+
static_assert(std::same_as<test_std::completion_signatures<test_std::set_value_t()>, type>);
184188
}

src/beman/execution26/tests/exec-then.pass.cpp

+4-3
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@ namespace
6262
test_std::completion_signatures<Completions...>,
6363
test_std::completion_signatures_of_t<decltype(sender), test_std::empty_env>
6464
>);
65-
};
65+
}
6666

6767
auto test_then_type() -> void
6868
{
69-
test_then_type< test_std::set_value_t()>(test_std::just() | test_std::then([]{}));
69+
test_then_type< test_std::set_value_t()>(test_std::just(0) | test_std::then([](auto){}));
7070
test_then_type< test_std::set_value_t(int)>(test_std::just() | test_std::then([]{ return 0; }));
7171
test_then_type< test_std::set_error_t(int)>(test_std::just_error(0) | test_std::then([]{ return 0; }));
7272
test_then_type< test_std::set_stopped_t()>(test_std::just_stopped() | test_std::then([]{ return 0; }));
@@ -150,6 +150,7 @@ namespace
150150
test_std::set_stopped_t()
151151
>() | test_std::upon_stopped([]{}));
152152
}
153+
153154
auto test_then_value() -> void
154155
{
155156
assert(std::tuple{17} == *test_std::sync_wait(
@@ -178,4 +179,4 @@ auto main() -> int
178179
test_then_type();
179180
test_then_multi_type();
180181
test_then_value();
181-
}
182+
}

0 commit comments

Comments
 (0)