-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to build full form of import notation #275
Comments
Its also needed for |
Can you collaborate on this a lil bit more? |
not really. In plugin I want notation-string to be unique. In general it is not required
add more info or make a PR ? Can do all two. You can assign it to me |
According to old known BEM Full Stack and their must-should-deps mess there can be different order if entities relates each to another with "should" (weak) link. I'd suggest to use the order of the first found set. It could be something like: const cache = {};
const method = (str) => {
const cells = parseImport(str);
const key = Array.from(new Set(cells.sort().map(c => c.id)).join(' ');
if (cache[key]) return cache[key];
return cache[key] = cells;
} But how many times I'll get js code of block if I import it few times in different places? It means we should group all js files of block with all their mods and then bake it to one Class with
It's the least I can do ;-D |
webpack-bem-plugin requests method:
import-notation-string -> import-notation-full-string
For now extending context process is integrated in parse method. Can we do a simple refactoring here?
The text was updated successfully, but these errors were encountered: