Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe lazyInit on mods from js tech #1583

Open
belozer opened this issue Jun 22, 2018 · 0 comments · May be fixed by #1584
Open

Safe lazyInit on mods from js tech #1583

belozer opened this issue Jun 22, 2018 · 0 comments · May be fixed by #1584

Comments

@belozer
Copy link
Member

belozer commented Jun 22, 2018

After #1579 lazyInit in declMod not allowed because it affects the base block.

But we can use another way.

In static props store regex list selectors for lazyInit.

_lazyInitBySelector : [
    { check : /(^|\s)block(\s|$)/, lazyInit : true },
    { check : /(^|\s)block_mod_/, lazyInit : false },
    { check : /(^|\s)block_mod_val(\s|$)/, lazyInit : true },
    { check : /(^|\s)block_boolmod(\s|$)/, lazyInit : false },
]

and check class list on dom node for detect lazy initialization.

@belozer belozer changed the title Safe lazyInit on mods Safe lazyInit on mods from js tech Jun 23, 2018
@belozer belozer linked a pull request Jun 23, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant