Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest exception when using a protected zip file (with password) in the application package #5

Closed
serge-xav opened this issue Mar 18, 2024 · 2 comments

Comments

@serge-xav
Copy link
Contributor

Content copied from threerings/getdown#276

If I add a password protected zip file in the application package, I get the following error with version 1.8.6 :

Exception in thread "main" java.io.IOException: Error computing digest for: externalProperties.zip
	at com.threerings.getdown.data.f.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.util.zip.ZipException: invalid CEN header (encrypted entry)
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(ZipFile.java:225)
	at java.util.zip.ZipFile.<init>(ZipFile.java:155)
	at java.util.zip.ZipFile.<init>(ZipFile.java:169)
	at com.threerings.getdown.data.Resource.computeDigest(Unknown Source)

The error is not present in version 1.7.X
I think the cause is the pull request threerings/getdown#206 (comment)

Solution proposal in the original issue is to fallback to the default digest calculcation, when the zip file is encrypted.

@bekoenig
Copy link
Owner

bekoenig commented Apr 5, 2024

Hej @serge-xav,

the latest 2.0.0-SNAPSHOT should fix this issue. Can you test and give me some response please?

Thank you very much!

@serge-xav
Copy link
Contributor Author

Hi @bekoenig, I will try to test it this week, even if I'm a bit busy those days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants