Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromFilename Plugin: Does not update tags with AsIs actions. #5413

Open
Siggless opened this issue Sep 8, 2024 · 0 comments
Open

fromFilename Plugin: Does not update tags with AsIs actions. #5413

Siggless opened this issue Sep 8, 2024 · 0 comments

Comments

@Siggless
Copy link

Siggless commented Sep 8, 2024

Problem

Using the fromFilename plugin on music files with blank Title tags, and choosing "Use as-is" options, does not update the tags.

Source file:
image

$ beet import "D:\BeetsTest"

Imported file:
image

I need to use the "Use as-is" option because none of the MusicBrainz candidates match.
Passing -A does the same.
I want it to update the Title tag from the filename, without then choosing a candidate for incorrectly updating the tags. I'm not sure what the intended behavior of the plug-in is here.

I've managed to achieve this by adding the following to the end of filename_task, however this applies the tags to both the source file and the imported file.

# Write the new tags now
for item in items:
    item.try_write()

I guess a better solution is to set the action of the manipulate_files task to action.RETAG, but I don't know how to edit subsequent tasks from the plug-in.

Setup

  • OS: Windows 11
  • Python version: 3.12.3
  • beets version: 2.0.0
  • Turning off plugins made problem go away (yes/no): n/a

My configuration (output of beet config) is:

directory: D:\BeetsTest\Library
library: D:\BeetsTest\musiclibrary.db

ignore:
    - Library   # Being written to during import
    - Various Artists

plugins: fromfilename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant