Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates plugin doc does not mention explicitly the effect of --full on copy/move/delete #5408

Open
nado opened this issue Sep 4, 2024 · 2 comments

Comments

@nado
Copy link

nado commented Sep 4, 2024

Problem

As title says, here are the mention of the argument and the config block:

https://beets.readthedocs.io/en/stable/plugins/duplicates.html

-F, --full            show all versions of duplicate tracks or albums
full: List every track or album that has duplicates, not just the duplicates themselves. Default: no

The copy/move/delete flags all mention taking effects on "matched" items, but nowhere can we read that the matched items are the one listed by the command and not the "files other than the best elected file to keep", which lead me to apply the move command to all my versions of duplicates.
Either reword copy/move/delete, or the --full to state that it "modifies the matched items to include all version of duplicate tracks/albums", which would then be consistent across the different options.

@bal-e
Copy link
Member

bal-e commented Oct 12, 2024

So using -F and -m together resulted in all your files being moved to a different directory?

We can note that effect on the website docs and in the CLI output (basically show all ... => operate on all ...). Does that sound adequate?

The behavior you found is quite strange, perhaps combining -F and -m should result in an error.

@nado
Copy link
Author

nado commented Oct 13, 2024

Sounds great to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants