[bug] Unbox nodes in GraalVM JIT IR causing compilation errors.

[andrii0lomakin]

The presence of the Unbox nodes in GrallVM IR is causing compilation errors.

There are several examples of such compilation crashes from this discussion #515 (reply in thread) and this one #516 (comment) .

[andrii0lomakin]

Because I am working on the generation of kernels from basic functions and passed to them functional interfaces and will have to deal with this issue anyway - #516 I will fix this bug first if there are no objections.

[andrii0lomakin]

Hi @jjfumero .
This is a small update from my side: I have fixed the issue that is shown in this test - #516 (comment). I tested only on the OpenCL platform. So, I will test on all platforms before committing the changes.

I am going to add a separate test suite to test support of primitive wrappers (obviously unboxing only; no method calls are supported), and it will include the currently failing test #515 (reply in thread) .

I suppose there will be other tests that need to be fixed.
So, how do you prefer that I submit this fix as a separate PR or provide PR for all fixed tests?

[jjfumero]

Hi @andrii0lomakin , we prefer separate PRs. You can submit incremental PRs to support more and more. The important thing is that the PRs can be reproduced with tests, and those tests can run on multiple platforms (OpenCL, PTX and SPIR-V).

[andrii0lomakin]

@jjfumero When you mean that you prefer incremental PRs did it imply that you use some kind of PR stacking tool or resolve all upcoming changes manually?

[jjfumero]

I meant. every PR is one fix, in the case you have different types of fixes.

[jjfumero]

I am closing this issue since the fix was provided and merged in #533