Add L parameter to login_redirect_url

[stat1x]

The L parameter is missing in the login_redirect_url so if I am on a page with L parameter set to 1 (my-site.com/index.php?id=111&L=1) and I don't have access to a file I need to download I am redirected to the login page but without the L parameter.

[frans-beech-it]

Hi,

As workarround you could adjust the login_redirect_url config in you LocalConfiguration.php based on the _GET['L'] param.

But PR's are welcome :)

[stat1x]

I'm gonna try to manage this PR. But I think there are several things to take into account.

1. The language parameter should be somehow added to the protected file URLs.
2. Modify the redirectToUrl method to add the L parameter to the $redirect_uri with GeneralUtility::_GET('L').

Do you think it is the right way to do it?

[frans-beech-it]

Yes that looks like whats needed:

1. Use the ResourceStorage::preGeneratePublicUrl signal to add the 'L' param to the url (but this should be added to the url by the core itself)
2. Change FileDumpHook::redirectToUrl() to add the extra replacement to the url
3. Update the documentation ;)

[stat1x]

(but this should be added to the url by the core itself)

You mean it's a missing feature from the core? Should I add a ticket on forge to get ride of it?

[fsaris]

Yes please

[stat1x]

Here is the link to the issue : https://forge.typo3.org/issues/87955

[eckonator]

Here is my (dirty?) solution for this problem. I'm running TYPO3 9.5.
I added this code into my AdditionalConfiguration.php and it's working for me:

//var_dump($GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['fal_securedownload']["login_redirect_url"]);
//echo "<br />";
$referrer = $_SERVER['HTTP_REFERER'];
if($referrer) {
    $parsedUrl = parse_url($referrer);
    $referrerRequestUri = $parsedUrl['path'];
    if($referrerRequestUri) {
        if(substr( $referrerRequestUri, 0, 4 ) === "/en/" || $referrerRequestUri === "/en") {
            $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['fal_securedownload']["login_redirect_url"] = "/en/download-denied/";
        } else if(substr( $referrerRequestUri, 0, 4 ) === "/fr/" || $referrerRequestUri === "/fr") {
            $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['fal_securedownload']["login_redirect_url"] = "/fr/telechargement-refuse/";
        } else {
            $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['fal_securedownload']["login_redirect_url"] = "/de/download-verweigert/";
        }
    //  var_dump($GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['fal_securedownload']["login_redirect_url"]);
    //  die();
    }
}

Maybe it helps someone else :-)