Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need automated Open API syntax validation on submitting PR to master #366

Open
ravi-prakash-v opened this issue Jun 16, 2023 · 13 comments · May be fixed by #443
Open

Need automated Open API syntax validation on submitting PR to master #366

ravi-prakash-v opened this issue Jun 16, 2023 · 13 comments · May be fixed by #443
Assignees
Labels
C4GT Community enhancement New feature or request Protocol Draft Draft specification submitted for protocol standard consideration

Comments

@ravi-prakash-v
Copy link
Collaborator

ravi-prakash-v commented Jun 16, 2023


Name: Protocol Specifications
Title: "Need automated Open API syntax validation on submitting PR to master"
Labels: C4GT Community


Description

Problem:
Sometimes when pull requests are merged, syntactical errors in the Open API document get committed on master.

Feature Request
An automated script that runs when creating a PR to the spec. It should validate transaction.yaml, meta.yaml, and registry.yaml against Open API 3.0 specification.

Goals

  • An automated script that runs when creating a PR to the spec. It should validate transaction.yaml, meta.yaml, and registry.yaml against Open API 3.0 specification.

Expected Outcome

  • Specs on master branch should not have any errors

Acceptance Criteria

  • Checks run on a PR with syntax errors in OpenAPI spec should fail
  • Checks run on a PR with no syntax errors in OpenAPI spec should pass

Implementation Details

Mockups / Wireframes


Project

Beckn

Organization Name:

Beckn Open Collective

Domain

Others

Tech Skills Needed:

Open API 3.0
Github actions
Node JS

Mentor(s)

Ravi Prakash

Complexity

Medium

Category

CI/CD

Sub Category

Backend, Research

@ravi-prakash-v ravi-prakash-v added the enhancement New feature or request label Jun 16, 2023
@ravi-prakash-v ravi-prakash-v changed the title Need automated Open API syntax validation before committing to master Need automated Open API syntax validation on submitting PR to master Jun 16, 2023
@Deekshithrathod
Copy link

@ravi-prakash-v This seems a fairly easy task, assuming that we can use this library & the GitHub actions can be configured easily as well. I have tried to find the guide for local setup but couldn't find one, can you please point me to it? And also feel free to assign it to me, if no one else is working on it.

@Sarfraz-droid
Copy link

we can also use https://github.com/IBM/openapi-validator . as a cli tool to validate open api syntaxes

@Deekshithrathod
Copy link

Deekshithrathod commented Jul 11, 2023

@Sarfraz-droid I will take a look at it.

@Deekshithrathod
Copy link

@ravi-prakash-v Just checked the GHA marketplace, there are some readily available OAS validator GitHub actions like this. Will this do? ( If yes, I will raise a PR ) or would you like to build the entire thing from scratch?

@c4gt-community-support
Copy link

c4gt-community-support bot commented Jul 17, 2023

Hi!
Mandatory Details - The following details essential to submit tickets to C4GT Community Program are missing. Please add them!

  • Product Name - Please add a heading called Product Name and mention the name of the product below it.

Without these details, the ticket cannot be listed on the C4GT Community Listing.

Please update the ticket

@ravi-prakash-v
Copy link
Collaborator Author

Hi @Deekshithrathod, that will work. Can you please raise a PR for this?

@Deekshithrathod
Copy link

@ravi-prakash-v Sure can do. Feel free to assign this to me.

@Deekshithrathod
Copy link

Deekshithrathod commented Jul 20, 2023

@ravi-prakash-v Raised a PR, do check & let me know if you have any suggestions.

@emmayank
Copy link
Collaborator

Hi @ravi-prakash-v , the PR has been raised for the above issue by @Deekshithrathod . Please find it here - #387

@emmayank emmayank added the Protocol Draft Draft specification submitted for protocol standard consideration label Oct 30, 2023
@priyakumari02
Copy link

@ravi-prakash-v , Can I work on this issue , I believe the skills of this project align to my skills. I would like to work on this issue.

@Yash-Sajwan24
Copy link

@ravi-prakash-v I understand the problem, and I believe I have the necessary skills. Could I have the opportunity to work on this?

@pradnya809
Copy link

Hello @ravi-prakash-v
I am a working professional with experience from 6 last months,
i would be excited to contribute, can you please assign me an issue?

@Y3ABHISHEK
Copy link

Hey @pradnya809 @Yash-Sajwan24
Please raise a draft PR directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C4GT Community enhancement New feature or request Protocol Draft Draft specification submitted for protocol standard consideration
Projects
None yet
9 participants