From 0bbc80473478b9c26ccb81b8a5dfbb2f97409764 Mon Sep 17 00:00:00 2001 From: MICHAELMUNAVU83 Date: Tue, 23 Jan 2024 13:36:42 +0300 Subject: [PATCH] Added code readability --- lib/elixir_conf_africa/accounts.ex | 3 +-- lib/elixir_conf_africa/paystack.ex | 4 ++-- lib/elixir_conf_africa/ticket_types.ex | 2 +- lib/elixir_conf_africa_web/live/event_live/index.ex | 3 ++- lib/elixir_conf_africa_web/live/paid_ticket_live/index.ex | 2 +- lib/elixir_conf_africa_web/live/ticket_live/form_component.ex | 3 +-- lib/elixir_conf_africa_web/live/unpaid_ticket_live/index.ex | 2 +- test/elixir_conf_africa/ticket_types_test.exs | 2 +- test/elixir_conf_africa/tickets_test.exs | 2 +- test/elixir_conf_africa_web/user_auth_test.exs | 2 +- test/support/factory.ex | 3 +-- 11 files changed, 13 insertions(+), 15 deletions(-) diff --git a/lib/elixir_conf_africa/accounts.ex b/lib/elixir_conf_africa/accounts.ex index ec7b802..cbc2b77 100644 --- a/lib/elixir_conf_africa/accounts.ex +++ b/lib/elixir_conf_africa/accounts.ex @@ -4,10 +4,9 @@ defmodule ElixirConfAfrica.Accounts do """ import Ecto.Query, warn: false + alias ElixirConfAfrica.Accounts.{User, UserNotifier, UserToken} alias ElixirConfAfrica.Repo - alias ElixirConfAfrica.Accounts.{User, UserToken, UserNotifier} - ## Database getters @doc """ diff --git a/lib/elixir_conf_africa/paystack.ex b/lib/elixir_conf_africa/paystack.ex index 8c6fa64..6b7a870 100644 --- a/lib/elixir_conf_africa/paystack.ex +++ b/lib/elixir_conf_africa/paystack.ex @@ -2,9 +2,9 @@ defmodule ElixirConfAfrica.Paystack do @moduledoc """ The Paystack module is responsible for all the interactions with the Paystack API """ - defp api_url(), do: "https://api.paystack.co/transaction/initialize" + defp api_url, do: "https://api.paystack.co/transaction/initialize" - defp paystack_headers(), + defp paystack_headers, do: [ { "Content-Type", diff --git a/lib/elixir_conf_africa/ticket_types.ex b/lib/elixir_conf_africa/ticket_types.ex index 07d7ea0..0432c77 100644 --- a/lib/elixir_conf_africa/ticket_types.ex +++ b/lib/elixir_conf_africa/ticket_types.ex @@ -6,8 +6,8 @@ defmodule ElixirConfAfrica.TicketTypes do import Ecto.Query, warn: false alias ElixirConfAfrica.Repo - alias ElixirConfAfrica.TicketTypes.TicketType alias ElixirConfAfrica.Tickets.Ticket + alias ElixirConfAfrica.TicketTypes.TicketType @doc """ Returns the list of ticket_types. diff --git a/lib/elixir_conf_africa_web/live/event_live/index.ex b/lib/elixir_conf_africa_web/live/event_live/index.ex index 4601a44..a9667da 100644 --- a/lib/elixir_conf_africa_web/live/event_live/index.ex +++ b/lib/elixir_conf_africa_web/live/event_live/index.ex @@ -1,7 +1,8 @@ defmodule ElixirConfAfricaWeb.EventLive.Index do use ElixirConfAfricaWeb, :live_view - alias ElixirConfAfrica.TicketTypes + alias ElixirConfAfrica.Tickets.Ticket + alias ElixirConfAfrica.TicketTypes @impl true def mount(_params, _session, socket) do ticket_types = TicketTypes.list_ticket_types_with_remaining_tickets() diff --git a/lib/elixir_conf_africa_web/live/paid_ticket_live/index.ex b/lib/elixir_conf_africa_web/live/paid_ticket_live/index.ex index e5e48c1..ca7f5bd 100644 --- a/lib/elixir_conf_africa_web/live/paid_ticket_live/index.ex +++ b/lib/elixir_conf_africa_web/live/paid_ticket_live/index.ex @@ -1,8 +1,8 @@ defmodule ElixirConfAfricaWeb.PaidTicketLive.Index do use ElixirConfAfricaWeb, :admin_live_view - alias ElixirConfAfrica.Tickets alias ElixirConfAfrica.Emails + alias ElixirConfAfrica.Tickets @impl true def mount(_params, _session, socket) do diff --git a/lib/elixir_conf_africa_web/live/ticket_live/form_component.ex b/lib/elixir_conf_africa_web/live/ticket_live/form_component.ex index 5b2c05c..c95c94c 100644 --- a/lib/elixir_conf_africa_web/live/ticket_live/form_component.ex +++ b/lib/elixir_conf_africa_web/live/ticket_live/form_component.ex @@ -1,8 +1,7 @@ defmodule ElixirConfAfricaWeb.TicketLive.FormComponent do use ElixirConfAfricaWeb, :live_component - - alias ElixirConfAfrica.Tickets alias ElixirConfAfrica.Paystack + alias ElixirConfAfrica.Tickets @impl true def update(%{ticket: ticket} = assigns, socket) do diff --git a/lib/elixir_conf_africa_web/live/unpaid_ticket_live/index.ex b/lib/elixir_conf_africa_web/live/unpaid_ticket_live/index.ex index b97c157..8fcab0c 100644 --- a/lib/elixir_conf_africa_web/live/unpaid_ticket_live/index.ex +++ b/lib/elixir_conf_africa_web/live/unpaid_ticket_live/index.ex @@ -1,10 +1,10 @@ defmodule ElixirConfAfricaWeb.UnPaidTicketLive.Index do use ElixirConfAfricaWeb, :admin_live_view + alias ElixirConfAfrica.Emails alias ElixirConfAfrica.Tickets alias ElixirConfAfrica.Paystack - alias ElixirConfAfrica.Emails @impl true def mount(_params, _session, socket) do {:ok, assign(socket, :ticket_collection, list_unpaid_tickets())} diff --git a/test/elixir_conf_africa/ticket_types_test.exs b/test/elixir_conf_africa/ticket_types_test.exs index 6aa866c..237c419 100644 --- a/test/elixir_conf_africa/ticket_types_test.exs +++ b/test/elixir_conf_africa/ticket_types_test.exs @@ -4,8 +4,8 @@ defmodule ElixirConfAfrica.TicketTypesTest do alias ElixirConfAfrica.Factory describe "ticket_types" do - alias ElixirConfAfrica.TicketTypes.TicketType alias ElixirConfAfrica.TicketTypes + alias ElixirConfAfrica.TicketTypes.TicketType @invalid_attrs %{name: nil, description: nil, price: nil} diff --git a/test/elixir_conf_africa/tickets_test.exs b/test/elixir_conf_africa/tickets_test.exs index 1a56961..f5948e8 100644 --- a/test/elixir_conf_africa/tickets_test.exs +++ b/test/elixir_conf_africa/tickets_test.exs @@ -1,8 +1,8 @@ defmodule ElixirConfAfrica.TicketsTest do use ElixirConfAfrica.DataCase - alias ElixirConfAfrica.Tickets alias ElixirConfAfrica.Factory + alias ElixirConfAfrica.Tickets alias ElixirConfAfrica.Tickets.Ticket describe "ticket" do diff --git a/test/elixir_conf_africa_web/user_auth_test.exs b/test/elixir_conf_africa_web/user_auth_test.exs index 4751396..d6d70d2 100644 --- a/test/elixir_conf_africa_web/user_auth_test.exs +++ b/test/elixir_conf_africa_web/user_auth_test.exs @@ -1,9 +1,9 @@ defmodule ElixirConfAfricaWeb.UserAuthTest do use ElixirConfAfricaWeb.ConnCase, async: true - alias Phoenix.LiveView alias ElixirConfAfrica.Accounts alias ElixirConfAfricaWeb.UserAuth + alias Phoenix.LiveView import ElixirConfAfrica.AccountsFixtures @remember_me_cookie "_elixir_conf_africa_web_user_remember_me" diff --git a/test/support/factory.ex b/test/support/factory.ex index f5da8a3..f9f02d8 100644 --- a/test/support/factory.ex +++ b/test/support/factory.ex @@ -1,10 +1,9 @@ defmodule ElixirConfAfrica.Factory do @moduledoc false use ExMachina.Ecto, repo: ElixirConfAfrica.Repo - + alias ElixirConfAfrica.Accounts.User alias ElixirConfAfrica.Tickets.Ticket alias ElixirConfAfrica.TicketTypes.TicketType - alias ElixirConfAfrica.Accounts.User def ticket_type_factory do %TicketType{