clean up sizeOfStringInKb

Author: beakerandjake

src/formatting.js

@@ -14,17 +14,8 @@ import { puzzleBaseUrl } from './api/urls.js';
  * @param {String} value - The value whose size to calculate.
  * @param {BufferEncoding} encoding - The strings encoding
  */
-export const sizeOfStringInKb = (value, encoding = 'utf-8') => {
-  if (value == null) {
-    throw new Error('null or undefined value');
-  }
-
-  if (value === '') {
-    return '0kb';
-  }
-
-  return `${(Buffer.byteLength(value, encoding) / 1000).toFixed(2)}kb`;
-};
+export const sizeOfStringInKb = (value, encoding = 'utf-8') =>
+  value ? `${(Buffer.byteLength(value, encoding) / 1000).toFixed(2)}kb` : '0kb';
 
 /**
  * Converts a duration in nanoseconds to a human readable duration, up to seconds.

tests/formatting.test.js

@@ -24,9 +24,13 @@ describe('formatting', () => {
   });
 
   describe('sizeOfStringInKb()', () => {
-    test.each([null, undefined])('throws if value is: "%s"', (value) => {
-      expect(() => sizeOfStringInKb(value)).toThrow('null or undefined');
-    });
+    test.each([null, undefined, 0, ''])(
+      'returns 0kb if value is: "%s"',
+      (value) => {
+        const result = sizeOfStringInKb(value);
+        expect(result).toBe('0kb');
+      }
+    );
 
     test.each([1234, {}])('throws if value is non-string: "%s"', (value) => {
       expect(() => sizeOfStringInKb(value)).toThrow(