Skip to content

Commit 802a2fb

Browse files
committed
fixes error update triggering unnecessary updates
1 parent d9c43d0 commit 802a2fb

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

src/lib/branch/useBranch.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ export default function useBranch(
2323
branchName.length > 0
2424
) {
2525
setLoading(true);
26-
setError(null);
26+
setError(undefined);
2727
fetch(
2828
`https://api.github.com/repos/${owner}/${repo}/branches/${branchName}`
2929
)
3030
.then(res => res.json())
3131
.then(data => {
3232
setLoading(false);
3333
setBranch(data);
34-
setError(null);
34+
setError(undefined);
3535
})
3636
.catch(e => {
3737
setLoading(false);

src/lib/branch/useBranches.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ export default function useBranches(
1515
useEffect(() => {
1616
if (repo && repo.length > 0 && owner && owner.length) {
1717
setLoading(true);
18-
setError(null);
18+
setError(undefined);
1919
fetch(`https://api.github.com/repos/${owner}/${repo}/branches`)
2020
.then(res => res.json())
2121
.then(data => {
2222
setLoading(false);
2323
setBranches(data);
24-
setError(null);
24+
setError(undefined);
2525
})
2626
.catch(e => {
2727
setLoading(false);

src/lib/release/useLatestRelease.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default function useLatestRelease(
1414

1515
useEffect(() => {
1616
if (owner && owner.length > 0 && repo && repo.length > 0) {
17-
setError(null);
17+
setError(undefined);
1818
setLoading(true);
1919

2020
fetch(`https://api.github.com/repos/${owner}/${repo}/releases/latest`)

src/lib/release/useTaggedRelease.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default function useTaggedRelease(
2222
tag &&
2323
tag.length > 0
2424
) {
25-
setError(null);
25+
setError(undefined);
2626
setLoading(true);
2727

2828
fetch(

src/lib/repository/useCollaborators.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ export default function useCollaborators(
1515
useEffect(() => {
1616
if (repo && repo.length > 0 && owner && owner.length) {
1717
setLoading(true);
18-
setError(null);
18+
setError(undefined);
1919
fetch(`https://api.github.com/repos/${owner}/${repo}/collaborators`)
2020
.then(res => res.json())
2121
.then(data => {
2222
setLoading(false);
2323
setCollaborators(data);
24-
setError(null);
24+
setError(undefined);
2525
})
2626
.catch(e => {
2727
setLoading(false);

src/lib/repository/useForks.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ export default function useForks(owner: string, repo: string): IForksResponse {
1010
useEffect(() => {
1111
if (repo && repo.length > 0 && owner && owner.length) {
1212
setLoading(true);
13-
setError(null);
13+
setError(undefined);
1414
fetch(`https://api.github.com/repos/${owner}/${repo}/forks`)
1515
.then(res => res.json())
1616
.then(data => {
1717
setLoading(false);
1818
setForks(data);
19-
setError(null);
19+
setError(undefined);
2020
})
2121
.catch(e => {
2222
setLoading(false);

0 commit comments

Comments
 (0)