Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Sersic splines #34

Open
bd-j opened this issue Jun 11, 2019 · 2 comments
Open

Speed up Sersic splines #34

bd-j opened this issue Jun 11, 2019 · 2 comments
Labels
enhancement

Comments

@bd-j
Copy link
Owner

bd-j commented Jun 11, 2019

Right now generating a proposal for a single source (even for the GPU) involves evaluating several bicubic splines and their derivatives using a loop over scipy.SmoothBivariateSpline objects in the CPU code. This is expensive (~150 microseconds for ten Sersic radii) and should be sped up to make sure proposals can be generated fast enough for the CPU.
@bd-j
Copy link
Owner Author

bd-j commented Mar 9, 2022

might be worth looking at RectBivariateSpline instead of SmoothBivariateSpline cc @stacchella

@bd-j
Copy link
Owner Author

bd-j commented Jun 7, 2022

We now use RectBivariateSpline which has better behavior. Timing tests compared to the pixel computation kernel remain to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bd-j