on vs bind

[RobertLowe]

It's odd that Socket inherits from EventEmitter but implements its own event cycle with bind

https://github.com/bcoin-org/bsock/blob/master/lib/socket.js#L19

https://github.com/bcoin-org/bsock/blob/master/lib/socket.js#L837-L887

I raise this issue because I was mistakenly using on and not bind so events we're firing, but there is something odd about the implementation as such, its managing two lifecycles one on the Socket, one internally on Events.

Perhaps as a solution, on could proxy to bind when sensible to maintain a consistent event emitter implementation

[pinheadmz]

Good question, I notice the implementation for bind and hook have blacklist checks -- it could simply be that @chjj wanted to protect the event emitter in applicaitons like bcoin and hsd.

[RobertLowe]

My guess is it to differentiate some Socket events and the internal events. That said, I don't see how a blacklist really provides any benefit here. Thanks