From c46cb2adb0ca5c433c9bfe91c7de7d6c0cbc3b22 Mon Sep 17 00:00:00 2001 From: Nick Phura Date: Thu, 15 Aug 2019 11:42:17 -0700 Subject: [PATCH] ACRFD-4-2: Update amendment text. --- src/app/services/application.service.spec.ts | 4 ++-- src/app/utils/constants/application.ts | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/app/services/application.service.spec.ts b/src/app/services/application.service.spec.ts index 961cd73a..f27d9bd6 100644 --- a/src/app/services/application.service.spec.ts +++ b/src/app/services/application.service.spec.ts @@ -275,9 +275,9 @@ describe('ApplicationService', () => { expect(service.getStatusStringLong(application)).toBe('Unknown Status'); }); - it('with status ABANDONED and reason AMENDMENT APPROVED - APPLICATION it returns "Amendment: Approved"', () => { + it('with status ABANDONED and reason AMENDMENT APPROVED - APPLICATION it returns "Decision: Approved ..."', () => { application = new Application({ status: 'ABANDONED', reason: 'AMENDMENT APPROVED - APPLICATION' }); - expect(service.getStatusStringLong(application)).toBe('Amendment: Approved'); + expect(service.getStatusStringLong(application)).toBe('Decision: Approved - Tenure Issued'); }); it('with status ABANDONED it returns "Abandoned"', () => { diff --git a/src/app/utils/constants/application.ts b/src/app/utils/constants/application.ts index 73a3817a..9106c2cb 100644 --- a/src/app/utils/constants/application.ts +++ b/src/app/utils/constants/application.ts @@ -77,7 +77,10 @@ export class StatusCodes implements ICodeSet { /** * Application Reason codes. * - * Note: the reason code indicates additional information about the status code. + * Note: + * - the reason code indicates additional information about the status code. + * - the reason codes don't have unique text, instead they use the same text as their Status + * counterpart: (Decision_Approved and Decision_Not_Approved). * * @export * @class ReasonCodes @@ -87,14 +90,14 @@ export class ReasonCodes implements ICodeSet { public static readonly AMENDMENT_APPROVED: ICodeGroup = { code: 'AMENDMENT APPROVED - APPLICATION', param: 'AA', - text: { long: 'Amendment: Approved', short: 'Amendment: Approved' }, + text: { long: 'Decision: Approved - Tenure Issued', short: 'Approved' }, mappedCodes: [] }; public static readonly AMENDMENT_NOT_APPROVED: ICodeGroup = { code: 'AMENDMENT NOT APPROVED - APPLICATION', param: 'ANA', - text: { long: 'Amendment: Not Approved', short: 'Amendment: Not Approved' }, + text: { long: 'Decision: Not Approved', short: 'Not Approved' }, mappedCodes: [] };