Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search by FOM# -Public interface #572

Open
4 tasks done
gormless87 opened this issue Jan 24, 2024 · 5 comments
Open
4 tasks done

Search by FOM# -Public interface #572

gormless87 opened this issue Jan 24, 2024 · 5 comments
Assignees
@ianliuwk1019
Labels
Feature

Comments

@gormless87
Copy link
Collaborator

gormless87 commented Jan 24, 2024 •
edited by ianliuwk1019
Loading

Describe the task
Users would like to search by FOM# in addition to <--nope-- the existing options of search by FSPID and--> FOM Name

Image

Acceptance Criteria

  • search field added to public UI
  • search field added to API
  • regenerate the api code for frontend
  • test for both existing and non-existing FOM id's

Additional context
@gormless87 gormless87 mentioned this issue Jan 24, 2024
Open
4 tasks
@gormless87 gormless87 added the enhancement New feature or request label Jan 24, 2024
@ianliuwk1019 ianliuwk1019 self-assigned this Apr 4, 2024
@ianliuwk1019
Copy link
Collaborator

ianliuwk1019 commented Apr 5, 2024 •
edited
Loading

From the past implementation, there is no "FSP ID" field for search in public (admin has FSP ID search).
Do we know if Julius would like to add this for search in public as well?

For "FOM #" search field, I will use "FOM ID" as the label for consistency between public/admin and add this field above the "Comenting Status" search field.
@OlgaLiber2

@OlgaLiber2
Copy link
Collaborator

@ianliuwk1019 the field should be the first one, before FOM holder name. I think everyone refers to it as "FOM number" from my understanding.

@ianliuwk1019 ianliuwk1019 mentioned this issue Apr 8, 2024
Merged
@ianliuwk1019
Copy link
Collaborator

  • No such FOM (999999999) => No result found.
    Image

  • Existing FOM(3880) => 1 result found.
    Image

ianliuwk1019 added a commit that referenced this issue Apr 10, 2024
@ianliuwk1019
feat: #572 public search by fom (#615)
6cd10bb 
* Initial add new search field (fom  #) projectId

* Add new projectId for ProjectFindCriteria.

* Update swagger spec for projectId search field addition.

* Add fomNumberFilter to public

* Add api-cliebnt for new 'projectId' search field for findPublicSummary.

* Add 'fomNumberParam' filter to public Find component and api call.

* Try removing inline javascript.

* Using type="text" instead of "number" type and add listener verifyFomNumberInput to restrict value.

* minor wording.
@ianliuwk1019
Copy link
Collaborator

Ready in TEST for qa.

@ianliuwk1019
Copy link
Collaborator

Released to production.

@OlgaLiber2 OlgaLiber2 added Feature and removed task enhancement New feature or request labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianliuwk1019 ianliuwk1019

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gormless87 @ianliuwk1019 @OlgaLiber2