From 215444e46ae19147146630bfa68585455bc7c0cf Mon Sep 17 00:00:00 2001 From: "to. sandra" <76515860+sandratoh@users.noreply.github.com> Date: Thu, 14 Mar 2024 15:55:45 -0700 Subject: [PATCH] Open alcs and portal document inline with standardized method (#1513) * Update ALCS CSP to allow file document storage source * Rename function name and update bg color * Update portal public documents and decision documents * Set browser tab title when opening alcs file inline * Change portal backend and frontend to retrieve filename from existing logic * Rename function to match alcs * Update alcs detail page open file logic --- alcs-frontend/nginx.conf | 2 +- .../application-details.component.html | 4 +- .../application-details.component.ts | 8 ++-- .../notice-of-intent-details.component.html | 16 +++---- .../notice-of-intent-details.component.ts | 4 +- .../notification-details.component.html | 8 ++-- .../notification-details.component.ts | 6 +-- .../application-document.service.ts | 11 +++-- .../application-submission.service.ts | 1 - alcs-frontend/src/app/shared/utils/file.ts | 25 +++++++---- .../application-details.component.html | 4 +- .../application-details.component.ts | 8 ++-- .../cove-details/cove-details.component.html | 4 +- .../cove-details/cove-details.component.ts | 8 ++-- .../excl-details/excl-details.component.html | 8 ++-- .../excl-details/excl-details.component.ts | 8 ++-- .../incl-details/incl-details.component.html | 8 ++-- .../incl-details/incl-details.component.ts | 8 ++-- .../naru-details/naru-details.component.html | 2 +- .../naru-details/naru-details.component.ts | 8 ++-- .../nfu-details/nfu-details.component.html | 2 +- .../nfu-details/nfu-details.component.ts | 8 ++-- .../parcel/parcel.component.html | 25 +++-------- .../parcel/parcel.component.ts | 8 ++-- .../pfrs-details/pfrs-details.component.html | 8 ++-- .../pfrs-details/pfrs-details.component.ts | 8 ++-- .../pofo-details/pofo-details.component.html | 6 +-- .../pofo-details/pofo-details.component.ts | 8 ++-- .../roso-details/roso-details.component.html | 6 +-- .../roso-details/roso-details.component.ts | 8 ++-- .../subd-details/subd-details.component.html | 4 +- .../subd-details/subd-details.component.ts | 8 ++-- .../tur-details/tur-details.component.html | 4 +- .../tur-details/tur-details.component.ts | 8 ++-- .../edit-submission/files-step.partial.ts | 8 ++-- .../other-attachments.component.html | 2 +- .../parcel-entry/parcel-entry.component.ts | 8 ++-- .../review-attachments.component.ts | 8 ++-- .../review-submit-fng.component.html | 12 ++--- .../review-submit-fng.component.ts | 8 ++-- .../review-submit.component.html | 16 +++---- .../review-submit/review-submit.component.ts | 8 ++-- .../decisions/decisions.component.html | 8 ++-- .../decisions/decisions.component.ts | 8 ++-- .../submission-documents.component.html | 44 +++++++++---------- .../submission-documents.component.ts | 8 ++-- .../lfng-review/lfng-review.component.html | 41 ++++++++++------- .../lfng-review/lfng-review.component.ts | 8 ++-- .../view-application-submission.component.ts | 8 ++-- .../edit-submission/files-step.partial.ts | 8 ++-- .../other-attachments.component.html | 2 +- .../other-attachments.component.ts | 4 -- .../parcel-entry/parcel-entry.component.ts | 8 ++-- .../additional-information.component.html | 2 +- .../additional-information.component.ts | 8 ++-- .../notice-of-intent-details.component.html | 6 +-- .../notice-of-intent-details.component.ts | 8 ++-- .../parcel/parcel.component.html | 25 +++-------- .../parcel/parcel.component.ts | 8 ++-- .../pfrs-details/pfrs-details.component.html | 8 ++-- .../pfrs-details/pfrs-details.component.ts | 8 ++-- .../pofo-details/pofo-details.component.html | 6 +-- .../pofo-details/pofo-details.component.ts | 8 ++-- .../roso-details/roso-details.component.html | 8 ++-- .../roso-details/roso-details.component.ts | 8 ++-- .../decisions/decisions.component.html | 8 ++-- .../decisions/decisions.component.ts | 8 ++-- .../submission-documents.component.html | 2 +- .../submission-documents.component.ts | 8 ++-- .../edit-submission/files-step.partial.ts | 8 ++-- .../other-attachments.component.html | 2 +- .../proposal/proposal.component.html | 2 +- .../notification-details.component.html | 6 +-- .../notification-details.component.ts | 8 ++-- .../proposal-details.component.html | 4 +- .../proposal-details.component.ts | 8 ++-- .../submission-documents.component.html | 44 +++++++++---------- .../submission-documents.component.ts | 8 ++-- .../decisions/decisions.component.html | 8 ++-- .../decisions/decisions.component.ts | 8 ++-- .../submission-documents.component.html | 44 +++++++++---------- .../submission-documents.component.ts | 7 +-- .../lfng-review/lfng-review.component.html | 2 +- .../lfng-review/lfng-review.component.ts | 7 +-- .../cove-details/cove-details.component.html | 2 +- .../cove-details/cove-details.component.ts | 9 ++-- .../excl-details/excl-details.component.html | 4 +- .../excl-details/excl-details.component.ts | 7 +-- .../incl-details/incl-details.component.html | 4 +- .../incl-details/incl-details.component.ts | 7 +-- .../naru-details/naru-details.component.html | 2 +- .../naru-details/naru-details.component.ts | 7 +-- .../nfu-details/nfu-details.component.html | 2 +- .../nfu-details/nfu-details.component.ts | 7 +-- .../pfrs-details/pfrs-details.component.html | 6 +-- .../pfrs-details/pfrs-details.component.ts | 7 +-- .../pofo-details/pofo-details.component.html | 28 ++++-------- .../pofo-details/pofo-details.component.ts | 7 +-- .../roso-details/roso-details.component.html | 4 +- .../roso-details/roso-details.component.ts | 7 +-- .../subd-details/subd-details.component.html | 2 +- .../subd-details/subd-details.component.ts | 7 +-- .../tur-details/tur-details.component.html | 2 +- .../tur-details/tur-details.component.ts | 7 +-- .../decisions/decisions.component.html | 8 ++-- .../decisions/decisions.component.ts | 8 ++-- .../submission-documents.component.html | 2 +- .../submission-documents.component.ts | 7 +-- .../additional-information.component.ts | 9 ++-- .../pfrs-details/pfrs-details.component.html | 4 +- .../pfrs-details/pfrs-details.component.ts | 9 ++-- .../pofo-details/pofo-details.component.html | 32 ++++---------- .../pofo-details/pofo-details.component.ts | 9 ++-- .../roso-details/roso-details.component.html | 32 ++++---------- .../roso-details/roso-details.component.ts | 9 ++-- .../submission-documents.component.html | 2 +- .../submission-documents.component.ts | 7 +-- .../additional-information.component.ts | 9 ++-- .../application-document.service.ts | 4 +- .../notice-of-intent-document.service.ts | 4 +- .../notification-document.service.ts | 4 +- .../file-drag-drop.component.html | 2 +- .../file-drag-drop.component.ts | 6 +-- .../owner-dialog/owner-dialog.component.ts | 5 ++- .../parcel-owners.component.html | 2 +- .../parcel-owners/parcel-owners.component.ts | 10 +++-- portal-frontend/src/app/shared/utils/file.ts | 8 ++-- .../application-document.controller.spec.ts | 1 - .../application-document.controller.ts | 3 +- ...tice-of-intent-document.controller.spec.ts | 1 - .../notice-of-intent-document.controller.ts | 3 +- .../notification-document.controller.spec.ts | 1 - .../notification-document.controller.ts | 3 +- .../application/public-application.service.ts | 4 +- .../public-notice-of-intent.service.ts | 4 +- .../public-notification.service.ts | 4 +- 136 files changed, 544 insertions(+), 574 deletions(-) diff --git a/alcs-frontend/nginx.conf b/alcs-frontend/nginx.conf index 1da2eb30aa..6ccc98d57e 100644 --- a/alcs-frontend/nginx.conf +++ b/alcs-frontend/nginx.conf @@ -19,7 +19,7 @@ http { add_header 'X-XSS-Protection' '1; mode=block'; add_header 'Strict-Transport-Security' 'max-age=31536000; includeSubDomains; preload'; add_header 'Cache-control' 'no-cache'; - add_header 'Content-Security-Policy' "default-src 'self';img-src 'self';style-src 'unsafe-inline' 'self';connect-src $ENABLED_CONNECT_SRC; font-src 'self' https://fonts.gstatic.com https://fonts.googleapis.com; base-uri 'self'; object-src 'none'; frame-src https://alcs-metabase-test.apps.silver.devops.gov.bc.ca https://alcs-metabase-prod.apps.silver.devops.gov.bc.ca;"; + add_header 'Content-Security-Policy' "default-src 'self';img-src 'self';style-src 'unsafe-inline' 'self';connect-src $ENABLED_CONNECT_SRC; font-src 'self' https://fonts.gstatic.com https://fonts.googleapis.com; base-uri 'self'; object-src https://nrs.objectstore.gov.bc.ca; frame-src https://alcs-metabase-test.apps.silver.devops.gov.bc.ca https://alcs-metabase-prod.apps.silver.devops.gov.bc.ca https://nrs.objectstore.gov.bc.ca;"; add_header 'Permissions-Policy' 'camera=(), geolocation=(), microphone=()'; add_header 'Referrer-Policy' 'same-origin'; diff --git a/alcs-frontend/src/app/features/application/applicant-info/application-details/application-details.component.html b/alcs-frontend/src/app/features/application/applicant-info/application-details/application-details.component.html index d2d5a050b7..aa03160e66 100644 --- a/alcs-frontend/src/app/features/application/applicant-info/application-details/application-details.component.html +++ b/alcs-frontend/src/app/features/application/applicant-info/application-details/application-details.component.html @@ -81,7 +81,7 @@
Type | -
+
+
diff --git a/portal-frontend/src/app/features/applications/view-submission/alc-review/submission-documents/submission-documents.component.ts b/portal-frontend/src/app/features/applications/view-submission/alc-review/submission-documents/submission-documents.component.ts
index 679fb8aa43..eb0d606fb9 100644
--- a/portal-frontend/src/app/features/applications/view-submission/alc-review/submission-documents/submission-documents.component.ts
+++ b/portal-frontend/src/app/features/applications/view-submission/alc-review/submission-documents/submission-documents.component.ts
@@ -4,7 +4,7 @@ import { MatTableDataSource } from '@angular/material/table';
import { BehaviorSubject, Subject, takeUntil } from 'rxjs';
import { ApplicationDocumentDto } from '../../../../../services/application-document/application-document.dto';
import { ApplicationDocumentService } from '../../../../../services/application-document/application-document.service';
-import { openFileIframe } from '../../../../../shared/utils/file';
+import { openFileInline } from '../../../../../shared/utils/file';
@Component({
selector: 'app-submission-documents',
@@ -30,10 +30,10 @@ export class SubmissionDocumentsComponent implements OnInit, OnDestroy {
});
}
- async openFile(uuid: string) {
- const res = await this.applicationDocumentService.openFile(uuid);
+ async openFile(file: ApplicationDocumentDto) {
+ const res = await this.applicationDocumentService.openFile(file.uuid);
if (res) {
- openFileIframe(res);
+ openFileInline(res.url, file.fileName);
}
}
diff --git a/portal-frontend/src/app/features/applications/view-submission/lfng-review/lfng-review.component.html b/portal-frontend/src/app/features/applications/view-submission/lfng-review/lfng-review.component.html
index 4b275a4502..6534dad454 100644
--- a/portal-frontend/src/app/features/applications/view-submission/lfng-review/lfng-review.component.html
+++ b/portal-frontend/src/app/features/applications/view-submission/lfng-review/lfng-review.component.html
@@ -13,20 +13,29 @@
Local/First Nation Gov Review> Download PDF - |
---|