Fix name of protoc_gen_star_v2 repo (bufbuild#900)

alexbozhenko · rodaine · web-flow · commit 965235737d43 · 2023-06-23T10:21:42.000-07:00
When this project is used in a repo that uses Gazelle, the build fails with the following error: bufbuild#535 (comment) That error was introduced when protoc_gen_star was updated to v2 in bufbuild#783 and `dependencies.bzl` was (I believe) manually updated. Should gazelle be used to update `dependencies.bzl`, it would choose `com_github_lyft_protoc_gen_star_v2` as a name for the repo, as I showed here: alexbozhenko#1 This PR updates all references to that repo to use the correct name, which is expected by Gazelle. PR was created with: ``` sed -i 's/com_github_lyft_protoc_gen_star/com_github_lyft_protoc_gen_star_v2/g' $(rg -l com_github_lyft_protoc_gen_star) ``` Co-authored-by: Chris Roche <github@rodaine.com>
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -22,8 +22,8 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//module",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/pluginpb",
     ],
 )
diff --git a/cmd/protoc-gen-validate-cpp/BUILD b/cmd/protoc-gen-validate-cpp/BUILD
@@ -22,8 +22,8 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//module",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/pluginpb",
     ],
 )
diff --git a/cmd/protoc-gen-validate-go/BUILD b/cmd/protoc-gen-validate-go/BUILD
@@ -22,8 +22,8 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//module",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/pluginpb",
     ],
 )
diff --git a/cmd/protoc-gen-validate-java/BUILD b/cmd/protoc-gen-validate-java/BUILD
@@ -22,8 +22,8 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//module",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/pluginpb",
     ],
 )
diff --git a/dependencies.bzl b/dependencies.bzl
@@ -218,7 +218,7 @@ def go_third_party():
     )
 
     go_repository(
-        name = "com_github_lyft_protoc_gen_star",
+        name = "com_github_lyft_protoc_gen_star_v2",
         importpath = "github.com/lyft/protoc-gen-star/v2",
         sum = "h1:keaAo8hRuAT0O3DfJ/wM3rufbAjGeJ1lAtWZHDjKGB0=",
         version = "v2.0.1",
diff --git a/example-workspace/dependencies.bzl b/example-workspace/dependencies.bzl
@@ -218,7 +218,7 @@ def go_third_party():
     )
 
     go_repository(
-        name = "com_github_lyft_protoc_gen_star",
+        name = "com_github_lyft_protoc_gen_star_v2",
         importpath = "github.com/lyft/protoc-gen-star/v2",
         sum = "h1:erE0rdztuaDq3bpGifD95wfoPrSZc95nGA6tbiNYh6M=",
         version = "v0.6.1",
diff --git a/module/BUILD b/module/BUILD
@@ -12,8 +12,8 @@ go_library(
         "//templates",
         "//templates/java",
         "//validate:validate_go",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//proto",
         "@org_golang_google_protobuf//types/known/durationpb",
         "@org_golang_google_protobuf//types/known/timestamppb",
diff --git a/templates/BUILD.bazel b/templates/BUILD.bazel
@@ -11,8 +11,8 @@ go_library(
         "//templates/go",
         "//templates/java",
         "//templates/shared",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
     ],
 )
 
diff --git a/templates/cc/BUILD.bazel b/templates/cc/BUILD.bazel
@@ -28,8 +28,8 @@ go_library(
     deps = [
         "//templates/shared",
         "@com_github_iancoleman_strcase//:strcase",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/known/durationpb",
         "@org_golang_google_protobuf//types/known/timestamppb",
     ],
diff --git a/templates/ccnop/BUILD.bazel b/templates/ccnop/BUILD.bazel
@@ -10,7 +10,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//templates/cc",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
     ],
 )
 
diff --git a/templates/go/BUILD.bazel b/templates/go/BUILD.bazel
@@ -14,7 +14,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//templates/goshared",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
     ],
 )
 
diff --git a/templates/goshared/BUILD.bazel b/templates/goshared/BUILD.bazel
@@ -26,8 +26,8 @@ go_library(
     deps = [
         "//templates/shared",
         "@com_github_iancoleman_strcase//:strcase",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/known/durationpb",
         "@org_golang_google_protobuf//types/known/timestamppb",
     ],
diff --git a/templates/java/BUILD.bazel b/templates/java/BUILD.bazel
@@ -28,8 +28,8 @@ go_library(
     deps = [
         "//templates/shared",
         "@com_github_iancoleman_strcase//:strcase",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
-        "@com_github_lyft_protoc_gen_star//lang/go",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//lang/go",
         "@org_golang_google_protobuf//types/known/durationpb",
         "@org_golang_google_protobuf//types/known/timestamppb",
     ],
diff --git a/templates/shared/BUILD.bazel b/templates/shared/BUILD.bazel
@@ -14,7 +14,7 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//validate:validate_go",
-        "@com_github_lyft_protoc_gen_star//:protoc-gen-star",
+        "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",
         "@org_golang_google_protobuf//proto",
     ],
 )

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ def go_third_party():`
`218`	`218`	`)`
`219`	`219`
`220`	`220`	`go_repository(`
`221`		`- name = "com_github_lyft_protoc_gen_star",`
	`221`	`+ name = "com_github_lyft_protoc_gen_star_v2",`
`222`	`222`	`importpath = "github.com/lyft/protoc-gen-star/v2",`
`223`	`223`	`sum = "h1:keaAo8hRuAT0O3DfJ/wM3rufbAjGeJ1lAtWZHDjKGB0=",`
`224`	`224`	`version = "v2.0.1",`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ go_library(`
`10`	`10`	`visibility = ["//visibility:public"],`
`11`	`11`	`deps = [`
`12`	`12`	`"//templates/cc",`
`13`		`- "@com_github_lyft_protoc_gen_star//:protoc-gen-star",`
	`13`	`+ "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",`
`14`	`14`	`],`
`15`	`15`	`)`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ go_library(`
`14`	`14`	`visibility = ["//visibility:public"],`
`15`	`15`	`deps = [`
`16`	`16`	`"//templates/goshared",`
`17`		`- "@com_github_lyft_protoc_gen_star//:protoc-gen-star",`
	`17`	`+ "@com_github_lyft_protoc_gen_star_v2//:protoc-gen-star",`
`18`	`18`	`],`
`19`	`19`	`)`
`20`	`20`