Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some form of font regression/e2e tests #9503

Open
2 tasks
HarveyPeachey opened this issue Oct 4, 2021 · 0 comments
Open
2 tasks

Implement some form of font regression/e2e tests #9503

HarveyPeachey opened this issue Oct 4, 2021 · 0 comments
Labels
cross-team For visibility for both World Service teams (Engage & Media) Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@HarveyPeachey
Copy link
Contributor

HarveyPeachey commented Oct 4, 2021

Is your feature request related to a problem? Please describe.
When carrying out the font replacement work for Bengali, Sinhala and Tamil, it was noticed that there was next to no regression tests for these services, the only test that did fail was a snapshot for Most Read which detected a change in a single font size change. We should have some coverage for regression of fonts that aren't just a LTR and RTL service which are used in a majority of our snapshot testing.

Describe the solution you'd like
Implement a form of regression tests that either explicitly check for fonts that should exist for each service. There could also be some form of e2e to detect if a font has loaded on a page correctly? Try and pair with a tester to come up with the best solution.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Checklist

Additional context
Add any other context or screenshots about the feature request here.

@HarveyPeachey HarveyPeachey added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. cross-team For visibility for both World Service teams (Engage & Media) labels Oct 4, 2021
@HarveyPeachey HarveyPeachey changed the title Implement some form of font regression tests Implement some form of font regression/e2e tests Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team For visibility for both World Service teams (Engage & Media) Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Development

No branches or pull requests

1 participant