Segment Dragging will out of waveform.

[jason30704]

Hello,
When enableSegmentDragging(true) is set, segment will not detect whether endTime is out of range.

1.mp4

[jason30704]

I'm not sure if this is an issue or not.
I can achieve almost complete functionality by trying the method below.

However, overlay does not stop perfectly like startMarker and endMarker.

1.mp4

[chrisn]

Yes, it's inconsistent. You can drag a segment so that it ends after the right edge of the waveform view, but dragging the segment marker is limited to the width of the waveform view.

[chrisn]

The code in Peaks.js that handles this is a bit complex, and takes into account the pixel position of the markers, not just their time position.

We could make the behaviour consistent (e.g, by allowing markers to be dragged beyond the visible window). But is this really a problem in practice?

[jason30704]

Thanks for reply.
From a user's perspective, I think it's strange that a segment would exceed the scope of a wave.
In practice, there really isn’t much of a problem.

[chrisn]

So, there are three separate changes we could make:

1. Allow point and segment handles to be dragged beyond the limit of the waveform view.
2. Limit point and segment dragging to within the waveform duration.
3. Limit point and segment times to within the waveform duration when calling peaks.points.add(), peaks.segments.add(), peaks.points.update(), and peaks.segments.update().

I'm hesitant about 2 and 3.