Skip to content

Commit c9e5b63

Browse files
authored
pin buildifier (#1131)
1 parent f569827 commit c9e5b63

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.bazelci/presubmit.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,5 +302,9 @@ tasks:
302302
# TODO: fix test targets in `crate_universe_windows_targets`
303303
test_targets: *crate_universe_windows_targets
304304
buildifier:
305-
version: latest
305+
# TODO: Version 5.0.0 introduced a ton of unused variable warnings in cases
306+
# that should have been accounted for by `_` prefixes on the variable. Buildifier
307+
# should ignore `_` prefixed variables when checking if something is unused
308+
# https://github.com/bazelbuild/buildtools/issues/1044
309+
version: 4.2.5
306310
warnings: "all"

0 commit comments

Comments
 (0)