Use test harness tests in rust_analyzer now that runfiles work on windows (#785)

Use test harness tests in rust_analyzer now that runfiles work on windows

Author: hlopko

test/rust_analyzer/aspect_traversal_test/BUILD.bazel

@@ -45,6 +45,5 @@ rust_test(
     srcs = ["rust_project_json_test.rs"],
     data = [":rust-project.json"],
     edition = "2018",
-    use_libtest_harness = False,
     deps = ["//tools/runfiles"],
 )

test/rust_analyzer/aspect_traversal_test/rust_project_json_test.rs

@@ -1,21 +1,27 @@
-use runfiles::Runfiles;
+#[cfg(test)]
+mod tests {
+    use runfiles::Runfiles;
 
-fn main() {
-    let r = Runfiles::create().unwrap();
-    let rust_project_path =
-        r.rlocation("rules_rust/test/rust_analyzer/aspect_traversal_test/rust-project.json");
+    #[test]
+    fn test_aspect_traverses_all_the_right_corners_of_target_graph() {
+        let r = Runfiles::create().unwrap();
+        let rust_project_path =
+            r.rlocation("rules_rust/test/rust_analyzer/aspect_traversal_test/rust-project.json");
 
-    let content = std::fs::read_to_string(&rust_project_path)
-        .expect(&format!("couldn't open {:?}", &rust_project_path));
+        let content = std::fs::read_to_string(&rust_project_path)
+            .expect(&format!("couldn't open {:?}", &rust_project_path));
 
-    for dep in &[
-        "lib_dep",
-        "extra_test_dep",
-        "proc_macro_dep",
-        "extra_proc_macro_dep",
-    ] {
-        if !content.contains(dep) {
-            panic!("expected rust-project.json to contain {}.", dep);
+        for dep in &[
+            "lib_dep",
+            "extra_test_dep",
+            "proc_macro_dep",
+            "extra_proc_macro_dep",
+        ] {
+            assert!(
+                content.contains(dep),
+                "expected rust-project.json to contain {}.",
+                dep
+            );
         }
     }
 }

test/rust_analyzer/merging_crates_test/rust_project_json_test.rs

@@ -1,8 +1,6 @@
-use runfiles::Runfiles;
-
 #[cfg(test)]
 mod tests {
-    use super::*;
+    use runfiles::Runfiles;
 
     #[test]
     fn test_deps_of_crate_and_its_test_are_merged() {

test/rust_analyzer/merging_crates_test_reversed/rust_project_json_test.rs

@@ -1,8 +1,6 @@
-use runfiles::Runfiles;
-
 #[cfg(test)]
 mod tests {
-    use super::*;
+    use runfiles::Runfiles;
 
     #[test]
     fn test_deps_of_crate_and_its_test_are_merged() {