fix: incorrect rustfmt edition query (#1582)

* fix: incorrect rustfmt edition query

This change fixes incorrect query gathering rust targets with an
explicitly specified edition.

The comment above the query states the following intention:

> Get all targets with the specified `edition` attribute.
> Except for targets tagged with `norustfmt`.
> And except for targets with a populated `crate` attribute since
> `crate` defines edition for this target

However, the actual query is:

```
let scope = set({scope})
in filter("^//.*\.rs$",
   kind("source file",
         deps(attr(edition, "{edition}", $scope)
         except attr(tags, "...", $scope)
         + attr(crate, ".*", $scope), 1)))
```

According to the query grammar[1], `X except Y + Z` parses as `(X
except Y) + Z)`, while the author's intention was clearly `X except (Y
+ Z)`. The fix changes the expression to `X except Y except Z` that
implements the original intention correctly.

Fixes #1579.

[1]: https://bazel.build/query/language#algebraic-set-operations

* Update tools/rustfmt/src/main.rs

Author: roman-kashitsyn

tools/rustfmt/src/main.rs

@@ -75,10 +75,10 @@ fn edition_query(bazel_bin: &Path, edition: &str, scope: &str, current_dir: &Pat
         //     Get all source files.
         //         Get direct dependencies.
         //             Get all targets with the specified `edition` attribute.
-        //             Except for targets tagged with `norustfmt`.
+        //             Except for targets tagged with `norustfmt`, `no-rustfmt`, or `no-format`.
         //             And except for targets with a populated `crate` attribute since `crate` defines edition for this target
         format!(
-            r#"let scope = set({scope}) in filter("^//.*\.rs$", kind("source file", deps(attr(edition, "{edition}", $scope) except attr(tags, "(^\[|, )(no-format|no-rustfmt|norustfmt)(, |\]$)", $scope) + attr(crate, ".*", $scope), 1)))"#,
+            r#"let scope = set({scope}) in filter("^//.*\.rs$", kind("source file", deps(attr(edition, "{edition}", $scope) except attr(tags, "(^\[|, )(no-format|no-rustfmt|norustfmt)(, |\]$)", $scope) except attr(crate, ".*", $scope), 1)))"#,
             edition = edition,
             scope = scope,
         ),