propagate dSYM bundles discovered within dynamic xcframeworks #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
force-pushed
the
aaronsky/2512-dynamic-xcframework-dsym-outputs
branch
from
fa84986 to
767820d
Compare
aaronsky
commented
Dec 15, 2024
| @@ -374,6 +400,9 @@ def _get_xcframework_library_with_xcframework_processor( | |||
|
|
|||
| return struct( | |||
| binary = binary, | |||
| # TODO(asky) | |||
| debug_info_binaries = [], | |||
There was a problem hiding this comment.
i don't actually think this can be implemented as-is, since the outputs are opaque
Comment on lines
+432
to
+433
| if ".framework/" not in file.short_path: | ||
| continue |
There was a problem hiding this comment.
needed to add this to keep static frameworks from failing in bundle_paths.farthest_parent (not sure if fail-by-default is the right call for that method)
| @@ -180,32 +168,6 @@ def _framework_search_paths(header_imports): | |||
| else: | |||
| return [] | |||
|
|
|||
| def _debug_info_binaries( | |||
There was a problem hiding this comment.
moved to framework_import_support.bzl
aaronsky
force-pushed
the
aaronsky/2512-dynamic-xcframework-dsym-outputs
branch
from
d4a85d4 to
5aa55b5
Compare
aaronsky
changed the title
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2512
This PR attempts to add automatic dSYM imports per target-triple for dynamic xcframeworks. It is a rough implementation with some appropriately sharp edges, due to my still-nascent familiarity with the codebase, but I've managed to prove it out at the day job. Hopefully this is acceptable!
Note: dSYMs for dynamic xcframeworks imported from outside the root module are not copied into bazel-out and their paths as viewed with cquery are under
external/relative to the output base. This is consistent with howdsym_importsare handled byapple_dynamic_framework_import.