Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite local settings when java_language_level is not set in bazelproject file #6970

Open
ThomasCJY opened this issue Nov 6, 2024 · 0 comments
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin type: bug

Comments

@ThomasCJY
Copy link

Description of the bug:

Background
Bazel Plugin always overwrites the local java language version settings and kotlin jvm target level version based on the java_language_level defined in the bazelproject file. However, when java_language_level doesn't get specified in bazelproject file, bazel project sync will use the default 1.8 java version instead.

Screenshot 2024-11-05 at 4 59 09 PM Screenshot 2024-11-05 at 4 58 51 PM

This is problematic because developers lose the ability to customize the java language and jvm target levels inside their IDE.

Expected behavior
Do not overwrite the current java language level and kotlin jvm target level when java_language_level is not defined inside bazelproject file

Which category does this issue belong to?

Intellij

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

  1. Create a kotlin based bazel project
  2. Do not define java_language_level in bazelproject file
  3. After first project sync, you can see the java language level and kotlin jvm target level has been set to 8 and 1.8
  4. Manually update those values in IDE settings to 11, save changes
  5. Do another bazel sync, notice that the values will be overwritten back to 1.8 again.

Which Intellij IDE are you using? Please provide the specific version.

No response

What programming languages and tools are you using? Please provide specific versions.

No response

What Bazel plugin version are you using?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@ThomasCJY ThomasCJY added awaiting-maintainer Awaiting review from Bazel team on issues type: bug labels Nov 6, 2024
@github-actions github-actions bot added the product: IntelliJ IntelliJ plugin label Nov 6, 2024
@mai93 mai93 removed their assignment Nov 19, 2024
@mai93 mai93 added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin type: bug
Projects
Status: Untriaged
Development

No branches or pull requests

2 participants