Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Manager #6265

Open
ahmedyarub opened this issue Mar 13, 2024 · 7 comments · May be fixed by #6364
Open

Target Manager #6265

ahmedyarub opened this issue Mar 13, 2024 · 7 comments · May be fixed by #6364
Assignees
Labels

Comments

@ahmedyarub
Copy link
Contributor

Description of the feature request:

Add a GUI for managing targets. This is a prerequisite for multi-project repo and caching.

Which category does this issue belong to?

No response

What underlying problem are you trying to solve with this feature?

Easier management of project view targets and better caching integration in the future.

What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.

All

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@ahmedyarub ahmedyarub added awaiting-maintainer Awaiting review from Bazel team on issues type: feature request labels Mar 13, 2024
@sgowroji sgowroji assigned mai93 and unassigned sgowroji and iancha1992 Mar 13, 2024
@sgowroji sgowroji added product: IntelliJ IntelliJ plugin more-data-needed Awaiting response from issue author and removed more-data-needed Awaiting response from issue author labels Mar 13, 2024
@tpasternak
Copy link
Collaborator

@blorente
Copy link
Collaborator

I'm all for easier target management, but could you expand on what you'd like the UI to do? Switch between project views? Modify the targets section of the current project view?

@ahmedyarub
Copy link
Contributor Author

Quick update: instead of creating a new window/modal, I'll add gutter buttons that can be used to add new directories, and enable/disable individual targets. This would later be integrated with my still-in-design "quick sync" feature. This is what I could do experimenting yesterday:
image
This button currently takes you to the Add Directory modal that already exists.

@ahmedyarub
Copy link
Contributor Author

Quick update
Untitled Project

@ahmedyarub
Copy link
Contributor Author

Next I'll:
1- Temporary button that appears asking to resync OR just reload directory structure (we use that a lot!).
2- A button to automatically scan for new folders/targets and add them to file.

The I would focus on smarter management for caching.

@tpasternak
Copy link
Collaborator

honestly I'm not sure if the "Add Directory to Project" button would be that useful if users can just add a new line there, but the gutter icons are pretty cool!

@ahmedyarub
Copy link
Contributor Author

honestly I'm not sure if the "Add Directory to Project" button would be that useful if users can just add a new line there, but the gutter icons are pretty cool!

I agree if you look at the button alone, but now imagine with me having a complete target manager there right on the editor. I think that the next iterations would make my idea clearer. And I'm still open to suggestions 😄

ahmedyarub added a commit to ahmedyarub/intellij that referenced this issue Apr 4, 2024
Add "Add Directory" button to the project view
Add directory toggle checkboxes to the project view
ahmedyarub added a commit to ahmedyarub/intellij that referenced this issue Apr 4, 2024
Add target toggle checkboxes to the project view
@tpasternak tpasternak linked a pull request Apr 5, 2024 that will close this issue
3 tasks
ahmedyarub pushed a commit to ahmedyarub/intellij that referenced this issue Apr 23, 2024
Remove redundant method
ahmedyarub pushed a commit to ahmedyarub/intellij that referenced this issue Apr 23, 2024
Readd required method
ahmedyarub pushed a commit to ahmedyarub/intellij that referenced this issue Apr 23, 2024
Update comment
ahmedyarub pushed a commit to ahmedyarub/intellij that referenced this issue Apr 23, 2024
Update comment
blorente added a commit that referenced this issue May 7, 2024
* Closes #6370
Add line numbers to text blocks and sections.
Create removeAll() method to remove all the instances of an item regardless of the line number

* Revert local change

* Fix Android SDK Platform section

* Fix Android SDK Platform section
Add new section items with dummy line number

* Fix list parser test

* #6370 Fix parsing

* #6370
Remove redundant method
Add constant for temporary line numbers

* Update base/src/com/google/idea/blaze/base/projectview/ProjectView.java

Co-authored-by: Borja Lorente <[email protected]>

* #6370
Do not add line numbers on printing sections

* Update aswb/src/com/google/idea/blaze/android/projectview/AndroidSdkPlatformSection.java

Co-authored-by: Borja Lorente <[email protected]>

* Update aswb/src/com/google/idea/blaze/android/projectview/AndroidSdkPlatformSection.java

Co-authored-by: Borja Lorente <[email protected]>

* Update aswb/src/com/google/idea/blaze/android/projectview/AndroidSdkPlatformSection.java

Co-authored-by: Borja Lorente <[email protected]>

* Update aswb/src/com/google/idea/blaze/android/projectview/AndroidSdkPlatformSection.java

Co-authored-by: Borja Lorente <[email protected]>

* Update base/src/com/google/idea/blaze/base/projectview/ProjectView.java

Co-authored-by: Borja Lorente <[email protected]>

* Update base/src/com/google/idea/blaze/base/projectview/section/sections/DirectorySection.java

Co-authored-by: Borja Lorente <[email protected]>

* Update base/src/com/google/idea/blaze/base/projectview/section/sections/AutomaticallyDeriveTargetsSection.java

Co-authored-by: Borja Lorente <[email protected]>

* #6370
Remove line calculation from print() methods

* #6370
Remove redundant method

* #6265
Update comment

* Update aswb/src/com/google/idea/blaze/android/projectview/AndroidSdkPlatformSection.java

Co-authored-by: Borja Lorente <[email protected]>

---------

Co-authored-by: Borja Lorente <[email protected]>
Co-authored-by: Ahmed Yarub Hani Al Nuaimi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants