Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakiness downloading bazel (on windows) #432

Closed
phlax opened this issue Mar 3, 2023 · 4 comments · Fixed by #529
Closed

Flakiness downloading bazel (on windows) #432

phlax opened this issue Mar 3, 2023 · 4 comments · Fixed by #529

Comments

@phlax
Copy link

phlax commented Mar 3, 2023

Our (Envoy) Windows CI seems to fail fairly frequently downloading the bazel bin:

2023/03/03 08:56:37 Downloading https://releases.bazel.build/6.0.0/release/bazel-6.0.0-windows-x86_64.exe...
2023/03/03 08:56:51 could not download Bazel: HTTP GET https://releases.bazel.build/6.0.0/release/bazel-6.0.0-windows-x86_64.exe failed: Get "[https://releases.bazel.build/6.0.0/release/bazel-6.0.0-windows-x86_64.exe"](https://releases.bazel.build/6.0.0/release/bazel-6.0.0-windows-x86_64.exe%22): net/http: TLS handshake timeout

https://dev.azure.com/cncf/envoy/_build/results?buildId=129800&view=logs&j=b840a642-5ff3-5357-2e4b-e06e40b0cffd&t=67965174-5100-5631-9dc0-68b9f0aacb53&l=56

i didnt notice this happening in other jobs - so i believe this is specific to windows - but im not certain of this

either way, im wondering if it would be possible to add some retry logic/config as i see discussed elsewhere

@celestialorb
Copy link

Slapped together a rather rudimentary implementation in #495 as I've been encountering issues while downloading where a basic retry would likely have solved it.

@phlax
Copy link
Author

phlax commented Sep 8, 2023

cc @akshaysngupta

@akshaysngupta
Copy link

@celestialorb's PR looks reasonable to me. Can someone from maintainers review this?

afq984 added a commit to afq984/bazelisk that referenced this issue Jan 17, 2024
bazelbuild@787006c
added support for retrying HTTP errors, this extend that to
retry when an HTTP connection cannot be made.

This helps when bazelisk failes to speak HTTP:

    2024/01/16 14:31:11 could not download Bazel: HTTP GET https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64 failed: Get "https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64": dial tcp 130.211.22.235:443: i/o timeout

Fixes: bazelbuild#432
afq984 added a commit to afq984/bazelisk that referenced this issue Jan 19, 2024
bazelbuild@787006c
added support for retrying HTTP errors, this extend that to
retry when an HTTP connection cannot be made.

This helps when bazelisk failes to speak HTTP:

    2024/01/16 14:31:11 could not download Bazel: HTTP GET https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64 failed: Get "https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64": dial tcp 130.211.22.235:443: i/o timeout

Fixes: bazelbuild#432
fweikert pushed a commit that referenced this issue Jan 19, 2024
787006c
added support for retrying HTTP errors, this extend that to
retry when an HTTP connection cannot be made.

This helps when bazelisk failes to speak HTTP:

    2024/01/16 14:31:11 could not download Bazel: HTTP GET https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64 failed: Get "https://releases.bazel.build/7.0.0/release/bazel-7.0.0-linux-x86_64": dial tcp 130.211.22.235:443: i/o timeout

Fixes: #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants