Skip to content

Commit 5bfcb1a

Browse files
authored
Stop registering a Go SDK in the Gazelle submodule (#411)
* Do not register a Go toolchain for ourselves This module can be used as a transitive dep, and so we want to avoid forcing users to futz with their SDKs. * Add a small comment
1 parent 60abca8 commit 5bfcb1a

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

gazelle/MODULE.bazel

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,7 @@ bazel_dep(name = "bazel_skylib", version = "1.3.0")
99
bazel_dep(name = "gazelle", repo_name = "bazel_gazelle", version = "0.28.0")
1010
bazel_dep(name = "rules_go", repo_name = "io_bazel_rules_go", version = "0.35.0")
1111

12-
go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
13-
14-
go_sdk.download(
15-
name = "go_sdk",
16-
version = "1.18",
17-
)
18-
19-
use_repo(go_sdk, "go_sdk")
20-
21-
register_toolchains("@go_sdk//:all")
12+
# `rules_go` will register a toolchain for us if the user doesn't do so
2213

2314
go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps")
2415

0 commit comments

Comments
 (0)