Skip to content

Commit 454b259

Browse files
authored
Replace outdated select() on --cpu with another flag ref (#570)
1 parent 25a8e9d commit 454b259

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

tests/selects_tests.bzl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ with_or_test = unittest.make(_with_or_test)
6969
def _create_config_settings():
7070
native.config_setting(
7171
name = "condition1",
72-
values = {"cpu": "ppc"},
72+
values = {"stamp": "1"},
7373
)
7474
native.config_setting(
7575
name = "condition2",
@@ -116,9 +116,9 @@ def _set_conditions(condition_list):
116116
fail("condition_list must be a list of 3 booleans")
117117
ans = {}
118118
if condition_list[0]:
119-
ans["//command_line_option:cpu"] = "ppc"
119+
ans["//command_line_option:stamp"] = "1"
120120
else:
121-
ans["//command_line_option:cpu"] = "k8"
121+
ans["//command_line_option:stamp"] = "0"
122122
if condition_list[1]:
123123
ans["//command_line_option:compilation_mode"] = "opt"
124124
else:
@@ -305,7 +305,7 @@ def _and_config_setting_group_all_matches_fail_test():
305305
###################################################
306306
and_config_setting_group_single_setting_matches_test = analysistest.make(
307307
_expect_matches,
308-
config_settings = {"//command_line_option:cpu": "ppc"},
308+
config_settings = {"//command_line_option:stamp": "1"},
309309
)
310310

311311
def _and_config_setting_group_single_setting_matches_test():
@@ -329,7 +329,7 @@ def _and_config_setting_group_single_setting_matches_test():
329329
###################################################
330330
and_config_setting_group_single_setting_fails_test = analysistest.make(
331331
_expect_doesnt_match,
332-
config_settings = {"//command_line_option:cpu": "x86"},
332+
config_settings = {"//command_line_option:stamp": "0"},
333333
)
334334

335335
def _and_config_setting_group_single_setting_fails_test():
@@ -497,7 +497,7 @@ def _or_config_setting_group_all_conds_match_test():
497497
###################################################
498498
or_config_setting_group_single_setting_matches_test = analysistest.make(
499499
_expect_matches,
500-
config_settings = {"//command_line_option:cpu": "ppc"},
500+
config_settings = {"//command_line_option:stamp": "1"},
501501
)
502502

503503
def _or_config_setting_group_single_setting_matches_test():
@@ -521,7 +521,7 @@ def _or_config_setting_group_single_setting_matches_test():
521521
###################################################
522522
or_config_setting_group_single_setting_fails_test = analysistest.make(
523523
_expect_doesnt_match,
524-
config_settings = {"//command_line_option:cpu": "x86"},
524+
config_settings = {"//command_line_option:stamp": "0"},
525525
)
526526

527527
def _or_config_setting_group_single_setting_fails_test():

0 commit comments

Comments
 (0)