You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Like "Move `scala_toolchains` to `scala/toolchains.bzl`",
removes the `scala_toolchains_repo` symbol from `scala/scala.bzl` and
makes it available from `scala/toolchains_repo.bzl`.
This avoids a future `test_scala_version 2.12.20` failure during Bazel 8
builds after adding `twitter_scrooge` toolchain support in the new
`test_version/version_specific_tests_dir/scrooge_repositories.bzl` file.
Otherwise, this new file would load `toolchains_repo` from
`scala/scala.bzl`. The `test_version/test_scala_version_.../WORKSPACE`
file generated from `test_version/WORKSPACE.template` would then
transitively load `.bzl` files with `rules_java` symbols, breaking the
test.
```txt
$ RULES_SCALA_TEST_ONLY="test_scala_version 2.12.20" ./test_version.sh
ERROR: Traceback (most recent call last):
File ".../external/rules_scala/scala/private/common_attributes.bzl",
line 18, column 28, in <toplevel>
"deps": attr.label_list(
Error in label_list:
Illegal argument: element in 'providers' is of unexpected type.
Either all elements should be providers,
or all elements should be lists of providers,
but got list with an element of type NoneType.
ERROR: Error computing the main repository mapping:
at test_version/test_scala_version_.../scrooge_repositories.bzl:1:6:
at .../scala/scala.bzl:30:5:
at .../scala/private/rules/scala_junit_test.bzl:5:5:
initialization of module 'scala/private/common_attributes.bzl' failed
```
0 commit comments