Skip to content

Commit 8577354

Browse files
authored
Fix an unused_dependency_checker_ignored_targets_issue (#1035)
1 parent c567dab commit 8577354

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

test/src/main/scala/scalarules/test/srcjars_with_java/BUILD

-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ scala_library(
1010
scala_library(
1111
name = "mixed_language_dependent",
1212
srcs = ["MixedLanguageDependent.scala"],
13-
unused_dependency_checker_ignored_targets = [":mixed_language_source_jar"],
1413
deps = [":mixed_language_source_jar"],
1514
)
1615

@@ -24,6 +23,5 @@ scala_library(
2423
scala_library(
2524
name = "java_dependent",
2625
srcs = ["JavaDependent.scala"],
27-
unused_dependency_checker_ignored_targets = [":java_source_jar"],
2826
deps = [":java_source_jar"],
2927
)
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package fish;
22

33
public class JavaSource {
4-
public static final String line = "one fish, two fish";
4+
// We do not make this final - a bug in dependency analyzer in 2.11
5+
// and below means that dependencies on static final variables are not
6+
// detected
7+
public static String line = "one fish, two fish";
58
}
Binary file not shown.

0 commit comments

Comments
 (0)