Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call rlocation once #267

Merged
merged 1 commit into from
May 3, 2024
Merged

Only call rlocation once #267

merged 1 commit into from
May 3, 2024

Conversation

illicitonion
Copy link
Collaborator

This leads to slightly faster runtime, and slightly less confusing error messages if the file can't be found.

@illicitonion
Only call rlocation once
62f55be 
This leads to slightly faster runtime, and slightly less confusing error
messages if the file can't be found.
@illicitonion illicitonion enabled auto-merge (squash) May 2, 2024 18:28
shs96c
shs96c approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illicitonion illicitonion merged commit 09685c3 into bazel-contrib:main May 3, 2024
2 checks passed
@illicitonion illicitonion deleted the rlocation-windows-only-once branch May 3, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illicitonion @shs96c