test(gazelle): Use json instead of color logs

Rely on json formatted logs to avoid postprecessing and unstable color format.

java/gazelle/lang.go

@@ -40,12 +40,23 @@ type javaLang struct {
 func NewLanguage() language.Language {
 	goLevel, javaLevel := logconfig.LogLevel()
 
-	logger := zerolog.New(zerolog.ConsoleWriter{Out: os.Stderr}).
-		With().
-		Timestamp().
-		Caller().
-		Logger().
-		Level(goLevel)
+	var logger zerolog.Logger
+	if os.Getenv("GAZELLE_JAVA_LOG_FORMAT") == "json" {
+		logger = zerolog.New(os.Stderr)
+	} else {
+		logger = zerolog.New(zerolog.ConsoleWriter{Out: os.Stderr})
+	}
+
+	if os.Getenv("GAZELLE_JAVA_LOG_TIMESTAMP") != "false" {
+		logger = logger.With().Timestamp().Logger()
+	}
+
+	if os.Getenv("GAZELLE_JAVA_LOG_CALLER") != "false" {
+		logger = logger.With().Caller().Logger()
+	}
+
+	logger = logger.Level(goLevel)
+
 	logger.Debug().Msg("creating java language")
 
 	l := javaLang{

java/gazelle/testdata/BUILD.bazel

@@ -8,10 +8,6 @@ load("@bazel_gazelle//:def.bzl", "gazelle_binary", "gazelle_generation_test")
 gazelle_binary(
     name = "gazelle",
     languages = [
-        # Register a fake language which makes timestamps consistent via static initializers.
-        # Otherwise we end up with stderr diffs every time we run the tests beacuse of timestamps.
-        # (Yes, this is a horrible hack).
-        "//java/gazelle/private/testutil/reset_zerolog_timestamps",
         "@bazel_gazelle//language/proto:go_default_library",
         "//java/gazelle",
     ],
@@ -32,6 +28,11 @@ gazelle_binary(
 [
     gazelle_generation_test(
         name = file[0:-len("/WORKSPACE")],
+        env = {
+            "GAZELLE_JAVA_LOG_CALLER": "false",
+            "GAZELLE_JAVA_LOG_FORMAT": "json",
+            "GAZELLE_JAVA_LOG_TIMESTAMP": "false",
+        },
         gazelle_binary = ":gazelle",
         gazelle_timeout_seconds = 30,
         test_data = glob(

java/gazelle/testdata/annotations/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/bin/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/bin_with_runtime_deps/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/custom_test_suffixes/expectedStderr.txt

@@ -1,4 +1,4 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example/child/grandchild package=org.junit
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example/child package=org.junit
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example package=org.junit
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example/child/grandchild","message":"Unable to find package for import in any dependency"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example/child","message":"Unable to find package for import in any dependency"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example","message":"Unable to find package for import in any dependency"}

java/gazelle/testdata/directive_exclude/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/grpc/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/inner_classes/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/interface_exports/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/lib/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/lib_with_complex_runtime_deps/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/lib_with_invalid_label_in_runtime_deps/expectedStderr.txt

@@ -1,2 +1,2 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
-12:00AM FTL java/gazelle/generate.go:XXX > label parse error error="label parse error: repository has invalid characters: \"@invalid:label\"" dep=@invalid:label file.Pkg=src/main/java/com/example/hello name=hello
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}
+{"level":"fatal","file.Pkg":"src/main/java/com/example/hello","name":"hello","dep":"@invalid:label","error":"label parse error: repository has invalid characters: \"@invalid:label\"","message":"label parse error"}

java/gazelle/testdata/lib_with_invalid_label_in_runtime_deps/src/main/java/com/example/hello/BUILD.out

@@ -0,0 +1,8 @@
+load("@rules_java//java:defs.bzl", "java_library")
+
+java_library(
+    name = "hello",
+    srcs = ["Hello.java"],
+    visibility = ["//:__subpackages__"],
+    runtime_deps = ["@invalid:label"],
+)

java/gazelle/testdata/lib_with_runtime_deps/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/lib_with_runtime_deps_and_map_kind/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/maven_with_collision/expectedStderr.txt

@@ -1,5 +1,5 @@
-12:00AM ERR java/gazelle/resolve.go:XXX > Append one of the following to BUILD.bazel:
-12:00AM ERR java/gazelle/resolve.go:XXX > # gazelle:resolve java com.google.common.primitives @maven//:com_google_guava_guava
-12:00AM ERR java/gazelle/resolve.go:XXX > # gazelle:resolve java com.google.common.primitives @maven//:com_google_guava_guava_sources
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/main/java/com/example/myproject package=com.google.common.primitives
-12:00AM FTL java/gazelle/lang.go:XXX > the java extension encontered errors that will create invalid build files
+{"level":"error","message":"Append one of the following to BUILD.bazel:"}
+{"level":"error","message":"# gazelle:resolve java com.google.common.primitives @maven//:com_google_guava_guava"}
+{"level":"error","message":"# gazelle:resolve java com.google.common.primitives @maven//:com_google_guava_guava_sources"}
+{"level":"warn","package":"com.google.common.primitives","from rule":"//src/main/java/com/example/myproject","message":"Unable to find package for import in any dependency"}
+{"level":"fatal","message":"the java extension encontered errors that will create invalid build files"}

java/gazelle/testdata/module_granularity_with_sources/expectedStderr.txt

@@ -0,0 +1 @@
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/packages/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/proto/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/stdlib/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/test_without_production_code/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}