test(gazelle): Use json instead of color logs

Rely on json formatted logs to avoid postprecessing and unstable color format.

Author: stevebarrau

java/gazelle/lang.go

@@ -40,12 +40,23 @@ type javaLang struct {
 func NewLanguage() language.Language {
 	goLevel, javaLevel := logconfig.LogLevel()
 
-	logger := zerolog.New(zerolog.ConsoleWriter{Out: os.Stderr}).
-		With().
-		Timestamp().
-		Caller().
-		Logger().
-		Level(goLevel)
+	var logger zerolog.Logger
+	if os.Getenv("GAZELLE_JAVA_LOG_FORMAT") == "json" {
+		logger = zerolog.New(os.Stderr)
+	} else {
+		logger = zerolog.New(zerolog.ConsoleWriter{Out: os.Stderr})
+	}
+
+	if os.Getenv("GAZELLE_JAVA_LOG_TIMESTAMP") != "false" {
+		logger = logger.With().Timestamp().Logger()
+	}
+
+	if os.Getenv("GAZELLE_JAVA_LOG_CALLER") != "false" {
+		logger = logger.With().Caller().Logger()
+	}
+
+	logger = logger.Level(goLevel)
+
 	logger.Debug().Msg("creating java language")
 
 	l := javaLang{

java/gazelle/private/testutil/reset_zerolog_timestamps/BUILD.bazel

@@ -8,10 +8,6 @@ load("@bazel_gazelle//:def.bzl", "gazelle_binary", "gazelle_generation_test")
 gazelle_binary(
     name = "gazelle",
     languages = [
-        # Register a fake language which makes timestamps consistent via static initializers.
-        # Otherwise we end up with stderr diffs every time we run the tests beacuse of timestamps.
-        # (Yes, this is a horrible hack).
-        "//java/gazelle/private/testutil/reset_zerolog_timestamps",
         "@bazel_gazelle//language/proto:go_default_library",
         "//java/gazelle",
     ],
@@ -32,6 +28,11 @@ gazelle_binary(
 [
     gazelle_generation_test(
         name = file[0:-len("/WORKSPACE")],
+        env = {
+            "GAZELLE_JAVA_LOG_CALLER": "false",
+            "GAZELLE_JAVA_LOG_FORMAT": "json",
+            "GAZELLE_JAVA_LOG_TIMESTAMP": "false",
+        },
         gazelle_binary = ":gazelle",
         gazelle_timeout_seconds = 30,
         test_data = glob(

java/gazelle/private/testutil/reset_zerolog_timestamps/constant_logger.go

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/private/testutil/reset_zerolog_timestamps/noop_language.go

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/BUILD.bazel

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}

java/gazelle/testdata/annotations/expectedStderr.txt

@@ -1,4 +1,4 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example/child/grandchild package=org.junit
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example/child package=org.junit
-12:00AM WRN java/gazelle/resolve.go:XXX > Unable to find package for import in any dependency from rule=//src/test/com/example package=org.junit
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example/child/grandchild","message":"Unable to find package for import in any dependency"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example/child","message":"Unable to find package for import in any dependency"}
+{"level":"warn","package":"org.junit","from rule":"//src/test/com/example","message":"Unable to find package for import in any dependency"}

java/gazelle/testdata/bin/expectedStderr.txt

@@ -1 +1 @@
-12:00AM WRN java/gazelle/private/maven/resolver.go:XXX > not loading maven dependencies error="open %WORKSPACEPATH%/maven_install.json: no such file or directory" _c=maven-resolver
+{"level":"warn","_c":"maven-resolver","error":"open %WORKSPACEPATH%/maven_install.json: no such file or directory","message":"not loading maven dependencies"}