Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken by change in GitHub source ZIP generation #200

Open
fmeum opened this issue Feb 1, 2022 · 3 comments
Open

Build broken by change in GitHub source ZIP generation #200

fmeum opened this issue Feb 1, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@fmeum
Copy link
Member

fmeum commented Feb 1, 2022

@stefanbucur In the last 12 hours, something changed in the way GitHub generates git archive ZIPs, which causes the build to fail due to checksum mismatches. This affects all users that do not currently have this dependency cached in their repository cache. For the full context, see bazel-contrib/SIG-rules-authors#11.

I filed a ticket with GitHub, but am unsure about what we should do in the meantime. TAR archives appear to be unaffected by the change, but I also wouldn't have expected ZIP archives to ever change. For example abseil doesn't publish their own release archives and exclusively relies on tags and the GitHub-generated files.

@fmeum
Copy link
Member Author

fmeum commented Feb 1, 2022

Looks like the change has been rolled back (see also https://bazelbuild.slack.com/archives/CA31HN1T3/p1643719616408949), so we there is no need for immediate action.

@stefanbucur
Copy link
Collaborator

The issue seems to be obsolete. Feel free to reopen if it's still relevant.

@stefanbucur stefanbucur closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2022
@stefanbucur stefanbucur added the wontfix This will not be worked on label Jun 19, 2022
@fmeum
Copy link
Member Author

fmeum commented Jun 19, 2022

@stefanbucur It's still relevant, but not urgent: bazel-contrib/SIG-rules-authors#11 (comment)

I don't seem to have rights to reopen.

@stefanbucur stefanbucur reopened this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants