Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding toolchains parameter to configure_make_variant #1217

Open
LeifAndersen opened this issue Jun 16, 2024 · 0 comments
Open

Consider adding toolchains parameter to configure_make_variant #1217

LeifAndersen opened this issue Jun 16, 2024 · 0 comments

Comments

@LeifAndersen
Copy link

I'm trying to use rules_foreign_cc to build qemu. And at the moment, I'd like to use the preinstalled pkgconfig and preinstalled meson toolchains.

Unfortunately, it seems like configure_make_variant only allows for me to pass in a single toolchain, so I can't do something like:

configure_make_variant(
    name = "qemu",
    lib_source = "@qemu_dist//:all_srcs",
    toolchains = ["@rules_foreign_cc//toolchains:preinstalled_meson_toolchain",
                  "@rules_foreign_cc//toolchains:preinstalled_pkgconfig_toolchain"]
)

Alternatively, if there was a way to compose toolchains, the existing toolchain parameter might work:

configure_make_variant(
    name = "qemu",
    lib_source = "@qemu_dist//:all_srcs",
    toolchain = compose_toolchains(["@rules_foreign_cc//toolchains:preinstalled_meson_toolchain",
                              "@rules_foreign_cc//toolchains:preinstalled_pkgconfig_toolchain"])
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant