Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reliance on ~ character for apparent->canonical repo name mapping #874

Open
alexeagle opened this issue Jun 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Collaborator

What happened?

We assume we can search for tilde here:
https://github.com/aspect-build/rules_js/blob/b1dc67f34cfbe06dac06ea7c708d48e869df733e/npm/private/npm_translate_lock_helpers.bzl#L519
but this is not a guarantee from Bazel.

context: https://bazelbuild.slack.com/archives/C014RARENH0/p1719237766005439 from @fmeum

PSA: It may be necessary for Bazel to change the separator character used in canonical repository names (currently ~) to fix bazelbuild/bazel#22865, maybe even already for 7.2.1. That means that it's a good time to remove any reliance on this particular character from rulesets. I just did this for Gazelle, which might provide some ideas on how to do this: bazelbuild/bazel-gazelle#1835

Version

HEAD

How to reproduce

No response

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label Jun 26, 2024
@alexeagle
Copy link
Collaborator Author

Note, https://gitlab.arm.com/bazel/toolchain_utils/-/commit/fc7d485887292676b5a87eb51c40f92aa6343b6b shows one approach for fixing this.
--incompatible_use_plus_in_repo_names was released in 7.3.0rc1, we should start testing all our repos with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant