Hmc proposed sample handling refactor #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 49.63% 50.08% +0.45%
==========================================
Files 121 122 +1
Lines 5815 5872 +57
==========================================
+ Hits 2886 2941 +55
- Misses 2929 2931 +2 ☔ View full report in Codecov by Sentry. |
|
Actually, let's leave it as it is, so we can keep the history. |
|
Looks good to me, just have to figure out the test failures. |
… error in mcmc_stepgit add -A ()
oschulz
force-pushed
the
hmc_proposed_sample_handling_refactor
branch
from
0b5e29f to
68565f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a modified version of the function
transition()from AdvancedHMC.jl to make the points that are proposed during the HMC algorithm accessible in BAT.Also refactors
StanHMCTuning()to work in the transformation based sampling framework.Original Function:
https://github.com/TuringLang/AdvancedHMC.jl/blob/878efce497852dfe0b6918e9de4b825706fa848a/src/trajectory.jl#L674