Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRamanSpectraWorkChain: the IntensitiesAverageWorkChain is not called correctly #65

Open
bastonero opened this issue Apr 19, 2024 · 0 comments
Labels
bug Something isn't working priority/required

Comments

@bastonero
Copy link
Owner

The function call:

    def run_intensities_averaged(self):
        """Run an `IntensitiesAverageWorkChain` with the calculated vibrational data."""
        self.ctx.intensities_average = AttributeDict({})
        for key, vibrational_data in self.ctx.vibrational_data.items():
            inputs = AttributeDict(self.exposed_inputs(IntensitiesAverageWorkChain, namespace='intensities_average'))
            inputs.vibrational_data = vibrational_data
            inputs.metadata.call_link_label = key

            future = self.submit(IntensitiesAverageWorkChain, **inputs)
            self.report(f'submitting `IntensitiesAverageWorkChain` <PK={future.pk}>.')
            self.to_context(**{f'intensities_average.{key}': future})

calls self.ctx.vibrational_data, which is not set anywhere. So it should be correct to just use self.outputs.vibrational_data.

@bastonero bastonero added bug Something isn't working priority/required labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/required
Projects
None yet
Development

No branches or pull requests

1 participant