Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Readability and Maintainability of truss_handle.py #1052

Open
AmadouO20 opened this issue Jul 30, 2024 · 3 comments
Open

Improve Readability and Maintainability of truss_handle.py #1052

AmadouO20 opened this issue Jul 30, 2024 · 3 comments

Comments

@AmadouO20
Copy link

Problem:
The truss_handle.py file has become difficult to read and maintain due to its complexity. To ensure the future of the codebase and to make it easier for new contributors/users to understand the file.

Proposed Solution:
Refactor Code into Smaller Functions
Adhere to Coding Standards: such as PEP 8 standards

Alternatives
Another alternative is FLAK8 and reduce the length of some lines.

Additional context
For example, the function docker_run in truss_handle.py can be refactored as it has >100 lines.

@sumerjoshi
Copy link
Contributor

@marius-baseten - any chance I can take this ticket?

@squidarth
Copy link
Collaborator

Hi @sumerjoshi, we are in the middle of making some bigger architectural changes to Truss, so this is much lower priority now (we don't have bandwidth to help with this either). Thanks so much for offering though!

@sumerjoshi
Copy link
Contributor

sumerjoshi commented Feb 4, 2025

@squidarth - thanks for the response. I'm pretty excited about ML (especially ML infra). Love the product and how fast the team iterates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants