Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook-output is hidden unless you're running with -v #1243

Open
jdelStrother opened this issue Nov 22, 2024 · 1 comment · May be fixed by #1289
Open

Hook-output is hidden unless you're running with -v #1243

jdelStrother opened this issue Nov 22, 2024 · 1 comment · May be fixed by #1289

Comments

@jdelStrother
Copy link

jdelStrother commented Nov 22, 2024

Is it an intentional choice that hook output is hidden unless either the hook fails, or you're running kamal with -v ?

pre-deploy.sample and post-deploy.sample both write stuff to stdout, but neither will get shown by default. Perhaps the run_hook method ought to include KAMAL.with_verbosity(:debug) do ... ?

@joelcogen
Copy link

👍 if you're writing to stdout in your hooks you would expect it to be shown imho

@jdelStrother jdelStrother linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants